Re: [hatari-devel] Enabling _FORTIFY_SOURCE for Debug builds? |
[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]
Hi, On 14.4.2024 19.38, Thomas Huth wrote:
Am Sun, 14 Apr 2024 13:09:43 +0300 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:But for reasons I mentioned, maybe it would still be useful to enable it when _not_ doing Debug build?When I tried to enable it in the Ubuntu pipelines manually, I got the error message that _FORTIFY_SOURCE got redefined. I think it depends on the value that you assign to the macro (either 1, 2 or 3) and the value that is pre-defined by the distro.
Good point, e.g. different Ubuntu versions seems to use different levels.
So it sounds best to me to let the distro choose it's preferred setting. We'll get test coverage via the CI anyway now, so you don't have to worry too much that we don't have enough coverage for this before doing a release.
Ok, thanks! - Eero
Mail converted by MHonArc 2.6.19+ | http://listengine.tuxfamily.org/ |