| Re: [hatari-devel] Enabling _FORTIFY_SOURCE for Debug builds? |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Enabling _FORTIFY_SOURCE for Debug builds?
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sun, 14 Apr 2024 09:26:30 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1713086796; bh=edXlQR7zF9xTOcEQW+beG05QSRCavLHEfnuoJKFrP7M=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=aJvEeIHikz5A2+CeDN/C5dQASlkqVVUxDOXBOGdGiqAJRG8cbSvpiZzIrXkr4PS8l 64jRWY4LAowKf+3esnpaiC4P+raUX8UT/jl2ghbQCBtBFGyWSMFbK2zBun2r5NmTBk rmY/aotyEUO3Uhprli2xQ3UFve7J+/JWMgmoX6B0prxNXeFyTZJbecKq4PjzGMp68Y BTtVCJaQYzrcSWGMQqJ4egTKOZn9Fl6K4hCFCZS1O2bSP7RvA4RgXGFeGsmxdvLkbH b6Fda49Ysep9bJWfwga4QreGFUQpW0DowYXzmWoJqSg4l+VOZlLdrNjDZQvDLdr2vJ KSsuGKMqjDjeA==
Am Sun, 14 Apr 2024 11:47:25 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi Thomas,
>
> On 13.4.2024 22.53, Thomas Huth wrote:
> > Weird, I'm using 3.27.7 (on Fedora), and for me, it does not add the -O0
> > after the -g ... but OK, if there are versions that add -O0 automatically,
> > it's likely better to remove the -D_FORTIFY_SOURCE again. Done now.
>
> Why you moved FORTIFY_SOURCE behind Debug check few months ago:
> https://github.com/hatari/hatari/commit/adc8ae2c9d0a28886e8f70f24ebfceb5097e54a0
> ?
>
> The reason for it being in the options was catching things before
> release i.e. before distros package new Hatari release and complain
> about things it warns about (some distros enable FORTIFY_SOURCE for
> packages, and Mac tooling also enables some similar checks).
>
> => Wouldn't it have made more sense to invert your Debug check?
Sorry, I don't quite get your suggestion... you noticed that the line was
completely commented out before adc8ae2c9d0a288, did you?
Thomas