| Re: [hatari-devel] WinUAUE CPU -> show EA |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] WinUAUE CPU -> show EA
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Tue, 28 Nov 2023 19:10:42 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1701195056; bh=IP0oCuUpUlt0kejV9IhUiHEbGNq2cI3wB8Par5Sw/aA=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:To; b=V06VRkteZQSB1cEucOmBZ35iDrSkyKGl+KtBR7fz+ZwfzpvfOzUkuuxOYku+hqvSZ RbosDbESRH69/Z9sGqv1CA6Y7GljXi+g994r/3blgjp+IsV8fCOCcKyopUb4hd0+h9 kj6CnlLotqUmhzwq9GkzzxnxuLzQi9bGU3dXTwHZFi7ZR/RDqCGI+DonGoFr0OUk68 oCLzofB9u97eJAPMYAVuB0+V4ZhelPnMw9gAS44NioDiB6RSIQQQr5GSGh1KMRNft4 nZ6NvCmtsjyvSd2NmUoo2pGNF4/GFDpdnUUGdf9UtqebjN/cNHFhgG6bwweRrPl0Mo XPoKR8+bKW1bQ==
> Am 28.11.2023 um 19:01 schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>
>
>>> Am 28.11.2023 um 18:10 schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
>>>
>>> Le 28/11/2023 à 18:00, Andreas Grabher a écrit :
>>>
>>> It does not affect the debugging output patch, but syncing with WinUAE: Was this left out intentionally?
>>> https://github.com/tonioni/WinUAE/commit/dd69a5ca3b55ce6bf49b7569f1df3b62618d6760 <https://github.com/tonioni/WinUAE/commit/dd69a5ca3b55ce6bf49b7569f1df3b62618d6760>
>>
>> Hi
>>
>> This part is not used in Hatari, you have "#ifndef WINUAE_FOR_HATARI" before so I didn't update it.
>> but you're right, it would be better to include it anyway.
>>
>> will fix this
>>
>> Nicolas
>
> It makes comparing to WinUAE easier. Thank you for adding it.
>
> Another minor suggestion:
> 68kDisass.c includes stMemory.h and tos.h. Both are unused and could be removed.
>
I just recognized they are in fact used, but only if HAVE_CAPSTONE_M68K is true. So probably these headers could be included conditionally.