| Re: [hatari-devel] 68030 and movem |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] 68030 and movem
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Mon, 18 Sep 2023 11:12:06 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1695028339; bh=qg0GK1bJc/1bGYKGq9KnpqQQVuG3ST7HV8v9X8uZQ3o=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:To; b=R7cvDcNRlbXpprhk9DDamMyBHectV8b9PxyYpTQ3K6gbBJ2njr88PChxsg6vv9YuG NzX9OWxgBKIf61OGOZXTp/eyJ8fYjqRW7F/iY46tFttf7BAdvOVZDcvxotDsFjnRlD VQlMFk02eJbRvbxCOsOPTVBe5lvGbctf34zdtVvOjHioJh3UNqyrDsG1nfYoOGXFuM nNwRu9EP+9z5h5h/NTfIvi0IL3lOmB+u+5rHU7obJNWuS/f64hJvAaNcIBGuGmbPaF u3i5VIwJi72VO1DVISjApOTJYfDycf3G8xPfQgRI73lwkxwTmlbVPoNHQ8oGakUoiG FK/a37lLekdIQ==
> Am 18.09.2023 um 10:51 schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
>
> Le 18/09/2023 à 10:46, Andreas Grabher a écrit :
>
>>> do you mean the ones that use "int predec = 0;" ? If so they should be optimized by the compiler.
>>>
>>> Nicolas
>>>
>> That is likely. But why do we add code just to optimize it away afterwards? At least it is bad for readability.
>
> I guess it's easier for Toni to have a smaller code patch in gencpu.c (which is already quite hard to read/follow and have all the important CPU logic) and leave it to the compiler to optimize cpuemu_xx.c files (which are generated files that not many people will read, except on specific opcodes' debugging)
>
> Nicolas
>
The patch is shorter, but not better readable. For example it needs some effort to understand what !i means. Readability of the generated files is essential for debugging.