Hi all,
I built and ran Hatari on my Mac. Hatari crashes every time I try to open the preferences dialog.
It looks like a problem was introduced in commit 957d7db465970d1e34fde4c17e067c2009b32b57. Since that commit, the function Midi_Host_GetPortName now falls back to a prefix match on the supplied port name. Unfortunately, the Mac GUI code supplies a NULL pointer here, which causes Midi_Host_GetPortName to blow up when it calls strlen on that NULL pointer.
Attached is a patch that causes the Mac GUI to match the behaviour of the SDL GUI by populating the name parameter from config. This appears to fix the crash (the preferences dialog can open without crashing Hatari now) but I don't know how to test whether PortMidi actually works.
How does the patch look? And do you have any further suggestions for testing this on my Mac?
Cheers,
Chris