Re: [hatari-devel] Lowering error level on the cirrus-ci for hatari ? |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx, Nicolas Pomarède <npomarede@xxxxxxxxxxxx>
- Subject: Re: [hatari-devel] Lowering error level on the cirrus-ci for hatari ?
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Tue, 25 Oct 2022 12:00:44 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1666699246; bh=qc6UJc2fOtE3bGdqP6bGW1acvv63QBUgNJXjRBH1pnI=; h=Date:Subject:To:From:From; b=lBl0NPNSc5Xn1dbZcpiA2jaQkW0HGrekF8lCT/D0ZIS+4AUQZwY6dWNgZmLOEbA4y W5B144MSEpiNr8EMr5eU+9JsF1+GceoQls1aj+w0761xCFK+79vusFxTUSvyNzRx1n 4TpsR/YoGd5fVRrTjRZqwrq0xBFIzqqlcOAS3FsjCKQeHgA29sJItT+JCqyX33HTS6 CutXHtEu/0NkK4d4CnGxze4h5zLi08h7Q2TPGh93J3s+f/NE8XZ0mw93giXFriM2vr +6DRjBxAtH4GYmJI6u5pjqzDty0xVu1xkmUdvoEoP6C5mgBolFDNe8sSZwsY4GheJ+ T7N9lkL1CrA9A==
On 25/10/2022 10.17, Nicolas Pomarède wrote:
Hi
with latest WinUAE's cpu changes, there're 2 unused variables. This can be
fixed easily (I reported to Toni to change it upstream if possible), but it
makes the compilation fails on cirrus-ci
https://cirrus-ci.com/github/hatari/hatari
....
Thomas, maybe it would be better to change flags to not fail on warnings but
to continue anyway ? (when compiling locally on my PC these 2 warnings are
not causing an error)
Hi,
I've used "--enable-werror" in the CI jobs on purpose - otherwise the
warnings would go completely unnoticed since nobody looks at the jobs output
logs when they are succeeding.
I think it's ok if the jobs are failing due to this for a while 'til we get
it fixed, but if it annoys you too much, feel free to add a
-Wno-error=unused-variable to src/cpu/CMakeLists.txt.
Thomas