Re: [hatari-devel] NetBSD loader for Hatari

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi Thorsten,

I noticed a potential bug NetBSD debug symbols handling code:
----------------------------------------------
....
+			if (symbols != NULL && strings != NULL)
+			{
+				/*
+				 * struct symbol_t needs a pointer, so we need to make a copy also of
+				 * the string table, since the kernel may move it around
+				 */
+				memcpy(strings, (char *)symtab + 
SDL_SwapBE32(shp[strtab_index].sh_offset), strtab_size);
+				esym = (Elf32_Sym *)(symtab + 
SDL_SwapBE32(shp[symtab_index].sh_offset));
+				symbolcount = 0;
+				for (i = 0; i < count; i++, esym++)
+				{
+					strx = SDL_SwapBE32(esym->st_name);
+					idx = SDL_Swap16(esym->st_shndx);
----------------------------------------------

Shouldn't it use SDL_SwapBE16()?


	- Eero


On 28.8.2022 9.42, Thorsten Otto wrote:
> On Sonntag, 28. August 2022 01:32:57 CEST Eero Tamminen wrote:
> > Are you sure you do not have any additional fixes no top of your last
> > patch series from July 27th?
>
> Yes, the last one being "Adjust statusbar when linux or netbsd are loaded"
>
> > Are you using NetBSD release kernels, or perhaps one you patched /
> > configured / built yourself?
>
> I'm currently using my own build, but the official version behaves the same.
> And the only thing i tried to change in the netbsd kernel is, to add support
> for modem2 output on falcon.
>
> > I'm applying your patch series against latest Hatari Git head, in case
> > that matters.
>
> Just did the same (one of the patches seems to be already applied), and still
> get the same result. In your config, do you emulate a Falcon or a TT?