Re: [hatari-devel] Patch for logging the full CDB

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

Btw. after Nicolas applied your patch, Linux 5.16 SCSI fail looks following:
----------------------------------------
scsi host0: Atari native SCSI, irq 39, io_port 0x0, base 0x0, can_queue 
16, cmd_per_lun 2, sg_tablesize 128, this_id 7, flags { }
HDC: INQUIRY (SCSI, t=0, lun=0, cdb=12:00:00:00:24:00)
scsi 0:0:0:0: Direct-Access     Hatari   EmulatedHarddisk 0180 PQ: 0 ANSI: 1
HDC: INQUIRY (SCSI, t=0, lun=1, cdb=12:20:00:00:24:00)
....
HDC: TEST UNIT READY (SCSI, t=0, lun=0, cdb=00:00:00:00:00:00).
HDC: READ CAPACITY (SCSI, t=0, lun=0, cdb=25:00:00:00:00:00:00:00:00:00)
sd 0:0:0:0: [sda] 8192 512-byte logical blocks: (4.19 MB/4.00 MiB)
HDC: MODE SENSE (SCSI, t=0, lun=0, cdb=1a:00:3f:00:04:00).
sd 0:0:0:0: [sda] Write Protect is off
sd 0:0:0:0: [sda] Mode Sense: 2c 00 1f ff
HDC: MODE SENSE (SCSI, t=0, lun=0, cdb=1a:00:08:00:04:00).
HDC: REQUEST SENSE (SCSI, t=0, lun=0, cdb=03:00:00:00:60:00).
WARN : HDC: *** Strange REQUEST SENSE ***!
sd 0:0:0:0: Device offlined - not ready after error recovery
----------------------------------------


	- Eero


On 11.3.2022 12.47, Uwe Seimet wrote:
> Instead of only logging some fields of the CDB (for some commands the field
> names of the current logging is not correct anyway) I suggest to apply the
> attached patch, so that all CDB fields are logged.
>
> Sample output:
>
> HDC: REQUEST SENSE (ACSI, t=0, lun=7, cdb=03:e0:00:00:12:00).
> HDC: SEEK (ACSI, t=0, lun=0, cdb=0b:00:00:00:00:00), LBA=0 -> OK
> HDC: Unsupported command (ACSI, t=0, lun=0, cdb=2b:00:00:00:00:00:00:00:00:00)!
> HDC: REQUEST SENSE (ACSI, t=0, lun=0, cdb=03:00:00:00:12:00).
> HDC: MODE SENSE (ACSI, t=0, lun=0, cdb=1a:08:3f:00:ff:00).
> HDC: INQUIRY (ACSI, t=0, lun=0, cdb=12:00:00:00:0f:00)
> HDC: Unsupported command (ACSI, t=0, lun=0, cdb=5a:08:3f:00:00:00:00:10:00:00)!
> HDC: REQUEST SENSE (ACSI, t=0, lun=0, cdb=03:00:00:00:12:00).
> HDC: Unsupported command (ACSI, t=0, lun=0, cdb=3e:00:00:00:00:00:00:00:00:00)!
> HDC: REQUEST SENSE (ACSI, t=0, lun=0, cdb=03:00:00:00:12:00).
> HDC: Unsupported command (ACSI, t=0, lun=0, cdb=46:02:00:00:00:00:00:00:fe:00)!
> HDC: REQUEST SENSE (ACSI, t=0, lun=0, cdb=03:00:00:00:12:00).
> HDC: Unsupported command (ACSI, t=0, lun=0, cdb=a0:00:00:00:00:00:00:00:01:08:00:00).
> HDC: REPORT LUNS (ACSI, t=0, lun=0, cdb=a0:00:00:00:00:00:00:00:01:08:00:00).
> HDC: INQUIRY (ACSI, t=0, lun=0, cdb=12:00:00:00:0f:00)
>
> Best regards
>
> Uwe