Re: [hatari-devel] Midi code improvements

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 14.12.2021 23.28, Nicolas Pomarède wrote:
> Le 14/12/2021 à 21:43, Eero Tamminen a écrit :
> > I've just pushed some MIDI functionality improvements.
> >
> > I have some pending commits that do not change existing functionality, 
> > just IMHO improve the code.  It needs small change in Mac GUI code 
> > though which I cannot build/test.
> >
> > Any quick comments on the attached changes?
>
> looks fine to me, I don't have any specific opinion on the midi part as 
> long as it works :) (as I don't really use midi I'm glad if you want to 
> work on it)

Thanks!

Then the next thing is for somebody having Mac build setup to verify 
that my small patch to gui-osx/PrefsController.m:

* Builds
* Mac GUI still works for MIDI


Btw. I initially did the Hatari MIDI API change in hopes that Hatari 
could get run-time detection of new MIDI devices.  However, PortMidi 
apparently detects new MIDI devices only after PmTerminate() & 
PmInitialize() cycle, which one obviously cannot do whenever Hatari 
devices dialog is opened.

I'm hoping that someday PortMidi would be capable of appending new 
devices to its device list even without re-init...


	- Eero