[hatari-devel] MIDI IRQ handling bug

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]

This is a multi-part message in MIME format.
Hi Nicolas,

Current Hatari IRQ handling is buggy for MIDI. Midi_UnInit() disables MIDI IRQ, but Midi_Init() does not enable it, only calling Midi_Reset() does, which does not happen on MIDI device change.

(Similarly to handling of RS232, SCC & printer devices, MIDI device change at run-time does not trigger reset.)

I tried calling Midi_Reset() directly from Midi_Init(), but that freezes Hatari at startup (to somewhere in interrupt handling code).

Attached patch seems to work, but I assume all the things done by Midi_Reset() should not be done just on device change.

Could you look into what's the correct fix?

	- Eero

Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/