Re: [hatari-devel] TRACE_VIDEO_RES / TRACE_VIDEO_SYNC ?

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 05/04/2021 à 15:53, Eero Tamminen a écrit :
> Hi,
>
> It seems a bit funny to "waste" specific tracing
> bits to items that have only single trace point:
> -------------------------------------------
> $ git grep -e TRACE_VIDEO_RES -e TRACE_VIDEO_SYNC
> src/debug/log.c:        { TRACE_VIDEO_SYNC       , "video_sync" } ,
> src/debug/log.c:        { TRACE_VIDEO_RES        , "video_res" } ,
> src/debug/log.h:#define TRACE_VIDEO_SYNC         (1<<0)
> src/debug/log.h:#define TRACE_VIDEO_RES          (1<<1)
> src/debug/log.h:#define TRACE_VIDEO_ALL         ( TRACE_VIDEO_SYNC | 
> TRACE_VIDEO_RES | TRACE_VIDEO_COLOR \
> src/video.c:    LOG_TRACE(TRACE_VIDEO_RES ,"shifter=0x%2.2X 
> video_cyc_w=%d line_cyc_w=%d @ nHBL=%d/video_hbl_w=%d pc=%x 
> instr_cyc=%d\n",
> src/video.c:    LOG_TRACE(TRACE_VIDEO_SYNC ,"sync=0x%2.2X video_cyc_w=%d 
> line_cyc_w=%d @ nHBL=%d/video_hbl_w=%d pc=%x instr_cyc=%d\n",
> -------------------------------------------
>
> Could either of those be used e.g. also for debug
> output on SDL2 resolution changes, or should that
> have its own trace bit?

Hi

the fact that res and sync traces are used at only one place doesn't 
mean it's not used extensively ; quite the contrary, if you want to 
debug fullscreen code or code that removes top/bottom borders, then it 
can be very useful to separate res and sync accesses.

So I'd rather keep those 2 bits available and separate.

what is the SDL2 resolution change you want to trace ? My feeling was 
that TRACE_xxxx bits were more about tracing emulation events, not host 
related calss.

Nicolas