Re: [hatari-devel] Suggested patch to fix problem handling STOP when DSP is active

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 29/10/2020 à 23:28, Eero Tamminen a écrit :
> Hi,
>
> On 10/29/20 11:41 PM, Nicolas Pomarède wrote:
> > good point, I did something to update MFP while in stop state, but DSP 
> > should also be updated as it's similar to MFP running in parallel of 
> > the CPU.
> >
> > But doing it on a 100 cycles basis is not really fully accurate, so I 
> > did the attached patch where DSP_Run is called on each loop during the 
> > STOP state (at the interval where MFP is updated too).
> >
> > Please check if it improves sound in your case (maybe it will require 
> > more CPU than your patch on every 100 cycles)
>
> This works as fine as my updated version of
> Roger's patch (see my previous mail), and
> IMHO should be included to next release, it's
> such a significantly improvement for EmuTOS.
>
> I don't think there's any significantly
> CPU usage difference.

OK, I will push it latter today.

> What about old AUE core, will you do similar
> change there, or will we just decide it's too
> inaccurate for DSP music playback anyway?
>
> (And going to be removed in few releases.)

nope, no need for old uae core, too old and not accurate enough. And it 
was often advertised to use new winuae cpu core for TT/Falcon, so I 
don't think anyone expect old uar core to work correctly in that case.

Nicolas