Re: [hatari-devel] Coding style

[ Thread Index | Date Index | More Archives ]

Le 20/10/2020 à 14:15, Eero Tamminen a écrit :

On 5/2/20 6:55 PM, Thomas Huth wrote:
Am Sat, 2 May 2020 18:02:26 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
[...]>> Our coding style document:

try to adapt to the coding style of the file that
you're currently editing.

- For new files, pick one of the existing coding
    styles, don't add a new one.

It still makes sense that you pick the coding style that is used in the
other files in the same folder, i.e. use the traditional coding style
in the src/ folder, use the WinUAE coding style in src/cpu/, etc.

As Nicolas agreed, maybe in that case we should
add Git commit hooks (after release) that enforce
these styles for the files in question?

(Preferably ask also Toni to do the same for
his project, so that we can adapt his settings,
to avoid our cpu/ folder settings changing
anything else than our own code changes.)

I'm not really fond of enforcing coding style at the git level and have your code changed once it has been pushed.

I'd rather have style "errors" spotted by humans and reported to be fixed by the maintainer/original coder of the involved part.


Mail converted by MHonArc 2.6.19+