| Re: [hatari-devel] Latest Hatari crashing |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Latest Hatari crashing
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sun, 16 Jun 2019 09:26:14 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1560669975; bh=11DscmB6lO33Iwp8WkfU1J8GXwgvuRjmQStRsgkcbq4=; h=Date:From:To:Subject:From; b=qND0zlnwJT+ozc/6wt9LIx5ydZzAMh8NUWUfUs//518I+N7uftDdseoNT1Lg4Bsel vJLPrpsJgllIptX0iJ4kqeifu3+R3HYDOHBjGxJ9lI7HJgqJzarzH5ECgQrcv/YYzo TM60zN+o7G9FQwR3axlUXb2zSm15BFpzx+wZ0GmiAnB/ujp2Eul3DewicrhFMotG5s 5p9TUsdeH/8FrkCjkiPjBFK+LfcGCY9UrjMbgNDiuxjGp3egwUvjndFgBhSZ+99tZq tZy8pxqvtyyDefJd418bszbyfNr3M9Xzeb6BzOCCM7WfKXJZXPQs3Il5sUTtDTDK5Y YpBGKmw5Dr+WA==
Am Sat, 15 Jun 2019 19:52:07 +0200
schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
> Le 15/06/2019 à 14:59, Thomas Huth a écrit :
> > On 15/06/2019 14.44, Uwe Seimet wrote:
> >> I just noticed that WORDPLUS is also crashing, same with
> >> HDDRUTIL.
> >
> > I think I know what's going on ... the fix is likely this one:
> >
> > diff a/src/cart_asm.s b/src/cart_asm.s
> > --- a/src/cart_asm.s
> > +++ b/src/cart_asm.s
> > @@ -339,6 +339,8 @@ clearmulti:
> > subq.l #1,d1
> > bne.s clearmulti
> > andi.l #$0f,d0
> > + tst.l d0
> > + beq.s cleardone
> > clearbytes:
> > clr.b -(a0)
> > subq.l #1,d0
> >
> > ... I've got to do some more testing first, though...
>
> Hi
>
> note that you can avoid the "tst.l d0" in that case and save a few
> cycles :)
Right, thanks, I always keep forgetting when one needs it and when it is
not required...
Anyway, I've committed the patch now, so this issue should now
hopefully be solved.
Thomas