[hatari-devel] Re: Hatari 2.0.0 fails to create symlinks in a chroot

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Hi,

On 11/18/2016 01:14 PM, Andrea Musuruane wrote:
    sorry for writing directly to you, but the hatari devel ML is
restricted and there is no bug tracker available.

We use mailing list(s) as "bug tracker" (and more persistent ones
are listed in Hatari documentation).  Like other bug trackers,
you can post bugs there after you've registered.  Registering
isn't restricted.

Of the mailing lists, on hatari-devel you get few mails every day,
on hatari-users, weeks can go without a single mail.


I was updating the Hatari RPM in Fedora to v2.0.0 and I noticed that
mimetype icon symlinks are not created.

rpmbuild doesn't use absolute paths but is uses a specific destination
directory. The code in share/CMakeLists.txt seems to ignore the
destination directory and it uses absolute paths for symlink creation.
Hence the failure.

As you can see, it's not an absolute path, unless you've explicitly
specified one for CMAKE_INSTALL_PREFIX, or left it at the CMake
default ("/usr/local") value:
---------- share/CMakeLists.txt ----------------
....
        foreach(type vnd.msa vnd.fastcopy x-stx)
install(CODE "execute_process(COMMAND ln -sf application-x-st-disk-image.png

${CMAKE_INSTALL_PREFIX}/${ICONDIR}/${size}/mimetypes/application-${type}-disk-image.png)
                                ")
        endforeach()
....
foreach(type vnd.msa vnd.fastcopy x-stx)
install(CODE "execute_process(COMMAND ln -sf application-x-st-disk-image.svg

${CMAKE_INSTALL_PREFIX}/${ICONDIR}/scalable/mimetypes/application-${type}-disk-image.svg)
                        ")
endforeach()
----------- CMakeLists.txt ---------------
if(NOT ICONDIR)
	set(ICONDIR share/icons/hicolor)
------------------------------------------

See:
https://cmake.org/cmake/help/v3.0/variable/CMAKE_INSTALL_PREFIX.html


	- Eero



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/