Re: [hatari-devel] Falcon video counter

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


I've just tested the new patch and it seems there's no change with the previous one (Ishar 1 and 2 don't start)


Le 16/11/2016 à 22:31, Eero Tamminen a écrit :
Hi,

On 11/16/2016 11:16 PM, Laurent Sallafranque wrote:
> I've done a quick test:
>
> Bound 3 works
> Bound 4 is freezed on the dolphin image
> Bound5 is only displaying the tiger image

Before my patch it stopped to white screen even before
showing "Bound 5" text.  Patch fixes just Videl address
counter freezes, not DSP sync ones. :-)


> Ishar 1 and 2 don't work better
> Ishar 3 is working

There's a problem with the patch, Video_EndHBL() shouldn't
be called with it, because video.c Video_RestartVideoCounter()
(which sets pVideoRaster() copied in Video_EndHBL()) isn't
called and starting Falcon with mono monitor would crash
to NULL pointer access when video.c:Video_EndHBL() tries to
copy raster line, like it's currently (uselessly) doing
with Hatari 2.0.

Attached is a new version.


    - Eero


Laurent



Le 16/11/2016 à 21:56, Laurent Sallafranque a écrit :
Hi,

I'll test the patch tonight ( I had in mind to test Ishar 1,2,3) ;)

I agree it may fix all of this, but that's not the good way to do it.
I have another version of the videl code that I'll try to reimplement
into this version of hatari (I did it with hatari v1.6).

Anyway, if this patch also solves the Ishar games, I think it should
be applied, also if I rework it later.
Maybe it was too early when I first tried to implement Videl.

Regards
Laurent

PS: I spent a lot of time with Mr Splash at the Sillyventure (the guy
who has coded falcamp and flaysid).
We've spent some time looking what's wrong with falcamp, I continue to
search with his help.
I wish I find the problem.




Le 16/11/2016 à 21:26, Eero Tamminen a écrit :
Hi,

On 11/16/2016 12:33 AM, Laurent Sallafranque wrote:
Thanks for this patch (remind me the command to include it in the
current version please).

At Hatari repo root:
    patch -p1 < videl-video-counter.patch


I'll have more time now that Sillyventure is over.
I'd like to retry to finish the Videl code I did 3 years ago.
> (it let Pinball dream work much better than the current version,
but need a better accurate CPU)

I'll test this patch.

Besides fixing DLDH2, it fixes also Moonspeeder preview 2
game, Bound3 & Bound5 demos (at least they start now), and
Hextracker gets past video address counter code [1].

I added info about these to compatibility doc.

If somebody has Ishar 1, 2 or 3, it would be good if
they could test whether it works with the patch.


    - Eero

[1] Hextracker doesn't seem to be otherwise Falcon compatible,
I guess that testing was from time when Paulo was trying
to use Hatari in making Hextracker Falcon compatible...

Le 15/11/2016 à 23:21, Eero Tamminen a écrit :
Hi,

Since Laurent moved all Videl register handling to falcon/videl.c
(sometime after Hatari v1.6), several programs have been broken
because that removed support for Falcon video address counter.

Attached is patch adding minimal support for that.  It fixes
"Lasers and Hommes" (DLDH2), that doesn't anymore freeze at
startup.  I assume the patch to fix most, if not all of those
regressions, but I haven't had yet time to test them.


Any comments on the patch?  Additional things that should be
taken into account / fixed (or at least add TODOs for)?


    - Eero

PS. Note that the patch needs to modify few items saved into
memory snapshots, so it breaks memory snapshot compatibility.


















Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/