Re: [hatari-devel] Keyboard shortcut definition dialog

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

Thanks, it's commited.


	- Eero

On 01/10/2016 05:29 PM, Thomas Huth wrote:
>   Hi Eero,
>
> Am Sun, 10 Jan 2016 16:26:49 +0200
> schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > On 12/28/2015 10:30 AM, Thomas Huth wrote:
> > > schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > > > Now it looks like user is selecting whether each shortcut
> > > > should be invoked with shortcut or not.  I.e. modifier
> > > > belonging to shortcut, instead of the other way round.
> > > >
> > > > It might be clearer if the modifier selection would be before
> > > > shortcut name, and name is indented a bit, to indicate that
> > > > shortcuts with and without modifier are two separate sets.
> > >
> > > Ok, feel free to re-arrange the dialog if that makes more sense.
> >
> > I think it's actually most clear to show both keys for
> > given shortcut, and have separate Define button for each.
> >
> > What do you think of the attached patch (it also tells
> > user if shortcut got changed because it was duplicate)?
>
> That indeed looks easier to use than my original version. Please
> go ahead and commit it!
>
>   Thanks,
>    Thomas