Re: [hatari-devel] ACSI: READ/WRITE (10) incorrectly evaluate block number

[Uwe Seimet <Uwe.Seimet@xxxxxxxxx>]

> Yes, I just pushed a little patch that resets the counters back to zero
> when A1 is low. Please test whether this cures your problem.
> 
> > By the way, the byte counters (bytecount/byteread) are probably not
> > reset to 0 when resetting Hatari. Whenever the ACSI emulation was
> > out-of-sync I had to restart Hatari in order to get things right
> > again. Just resetting the emulation did not help.
> 
> You're right, the counters were not resetted here, too. However, this
> problem should also be fixed by the A1-patch, so I did not add an
> additional reset handler here.

At least it's different now. I can start my test program now several
times and the results are reproducible, which they weren't before this
patch. I cannot run all tests, though, because REPORT LUNS (Opcode 0xa0)
is not yet rejected but reports and endless number of LUNs - 67108864 or
so, which is unlikely to be correct ;-) - so I have to abort the
remaining tests. See the attachment for details.

Take care

Uwe

Found SCSI Driver version $0101

Buses:
  ID: 0, Name: 'Atari ACSI', Transfer length: 130560 ($1FE00)
  ID: 1, Name: 'Atari SCSI', Transfer length: 268435456 ($10000000)
  ID: 2, Name: 'Atari IDE', Transfer length: 130560 ($1FE00)

Testing bus 'Atari ACSI (ICD)', device ID 0
  CheckDev()
    Checking with illegal bus ID
    Checking with illegal SCSI ID
    Checking with legal bus and SCSI ID
  Open/Close()
    Available handles: 27
  INQUIRY
    Calling with legal data
      Device name: 'Hatari  EmulatedHarddisk', Firmware revision: '0180', Additional length: $1F
    Calling with non-existing LUN 7
  READ CAPACITY
    Reading capacity with READ CAPACITY (10)
      Number of blocks: 800800, Block size: 512
    Reading capacity with READ CAPACITY (16)
    Reading last block (800799)
    Reading last block + 1 (800800)
    ERROR: Call was not properly rejected
      Expected: SenseKey $05 ($04), ASC $21 ($01)
  READ
    Reading block 0 with READ (6)
    Reading block 0 with READ (10)
    Reading block 0 with READ (16)
    ERROR: Block contents differ at offset 0
    Reading block 0 to odd address
    Reading block 0 from non-existing LUN 7
    ERROR: Call was not properly rejected
      Expected: SenseKey $05 ($00), ASC $25 ($00)
  REPORT LUNS
    Number of LUNs: 67108864
      List of LUNs: 536870968, 4001866, 270925824, 131072000, 888668379, 1609564220, 942669826, 1919492128, 1635018084, 536870912, 800800, 0, 16777216, 0, 256, 0, 22360, 79096, 3955748, 0, 512, 0, 4001948, 3969192, 3955312, 0, 61, 0, 1996478020, 1245932830, 1111494707, 4002068, 1111494707, 1742492227, 1112683055, 282297, 947925527, 1320747069, 2896000, 486035061, -1300496287, 8020760, 1694937212, -1334050689, 6252036, 1111568385, 272125935, 1879789241, 1111705593, 1241055294, 839111233, 1320747069, 805521600, 134230531, 1105985825, 4039714, 808652820, -1763564984, 1220601224, 839116617, 24891585, -1541254589, 1839099905, 1057047531, 1111650315, -188721073, 1715880515, -414658493, -759156221, 544348160, -1541263357, 1139540347, -767342399, 402673337, 1380169340, 1341063248, 1316309223, -22657543, 645464126, 4034946, 4035470, 35941380, 1111699971, 4035722, 204144642, 1912692738, 1320747069, 1879396025, 1245931020, 34301444, 1111584773, -1807863293, 4035722, 1320747069, 1057114691, 17981444, 1879454751, -1797884927, 1728459306, 841679368, 1320747069, 1728450602, 271254021, 1320747069, 22548639, 942276886, 34361924, 4071746, 1320747069, 576671417, 1414510716, 1108758201, 1274609726, 4070176, 541871802, 939552256, 1111584778, -1738641403, -1799996416, 4035766, 1879658170, -931364865, 1728493692, 1246127884, 541871801, 1246062348, 541871801, 1111510713, 1621635076, -1805224790, 1320747069, 4070176, -909236, 1481619580, 12630140, 12087809, 4035858, 1879592633, 1006641230, -351650304, 93186, 1729508677, 18101575, 22418768, 927269382, -1100283380, 34345003, 394002433, 22419280, 34304005, -1799992768, 35933881, 1879119680, 34238471, -1799992768, 35933881, 1879185216, 34229945, 1245931008, 943880, 1711276200, 1105920014, -1541257105, 4071749, 4022838, 943624, 560881670, 561327880, 1711817209, 1611022841, 789071983, 13910511, -233549841, 1732294780, 808059428, 4007582, 1111638593, 1320747068, 1320747068, 4026532, 35930583, 632442553, 1341063514, 1316303360, 1106837566, 575161321, 33964610, -1300463624, 1728328385, 1380110912, 1843806801, 523784175, 934467, 1106837566, 100156904, 1206910976, 799791, -448146878, 4128342, -1267138498, 1320747069, 1730301625, 1106837566, 1320747069, 1711943531, 782958940, -1849408953, 1220595840, 1380433532, 795803652, 7741999, 937657, 675815504, 2029994565, 303608367, 839207105, -1673216910, 897980416, -1236964350, 32730118, 1859013189, 1220595840, -1133377536, 134238789, 906318511, 569495, 841679368, 1612476671, -796904910, 34092039, -747493376, 1860186115, 1114769408, -1853730833, 486035061, -1517328890, 1316303872, 1106837566, 1610765384, -1304400650, 805326453, 1829122108, 1879167041, 4105615, -801026443, 100155897, -792567806, 1728361024, 1728327680, 1316295737, 1712212545, -801021950, 872465916, 4119692, 1610765385, -1304400138, 1644441617, 1316309223, 939608057, 875233828, 1173946430, 1712332882, 1216368313, 1613918211, 1912914500, 35926531, 838885388, 35933882, 542253096, 4028138, 1711276218, 1728053426, 11318908, 10757714, 676020804, 1414279188, 1862711420, -1235982796, 1879167045, 839207105, 134223872, 32665060, 1816948737, -796900749, -1199832589, 4039642, 1730296380, 805652672, -767211327, 134223872, 1877368836, 948126315, 293339139, 4026532, 1316309223, 939607545, 1879461561, 675825657, 1108588156, 1879330489, 625476164, 1320747069, 38289936, 808059428, 1245932596, 1711566852, 541871801, 1396719360, 1711677546, 543818312, 3976306, 304742575, 1320747069, 11552897, 4035646, 457445418, 1430265932, -1789915094, 1105985544, -1789890559, 1057047532, -1686974, 1057114692, 1610772996, 543105631, 1481586688, 4035766, 1880313529, 356516016, 4035976, 11616748, 4035976, 841613900, 4071859, 4011406, 1320871244, -380489724, 1730040640, 808189936, 1610772735, 1320747069, 1320747069, 471354997, 4106184, 451169909, 608713216, 339279934, 1245800206, 1216368314, 1712992260, 1863192626, 1320875586, 1879138306, 70798965, 1364143176, 1173946430, 35941636, 1111515136, 4035012, -28438486, 1241055292, 1241055292, 541937337, 905977977, 795344900, 22552581, -1516884920, 537218745, 1006645806, 576115392, 1318341184, 839266350, 1320877858, 808124770, -767352827, 1916416543, 271188142, 1397113415, 11429680, 841875460, -758763517, 1006660874, 1716706391, 1565409862, 1842765888, 290052, 271188143, 3956408, 3956484, 576073731, 1006660868, 1401248846, 1250258146, 872624646, 542527162, 1712197674, -9940410, 1246193488, 1862684345, 1320873554, 658506072, 1320747069, 23081478, 1320747069, 23212591, 1320747069, 420896, 1990746136, 1728466617, 272171070, 1320871666, 1289714936, 524177391, 65778, 15740796, 15221423, 4105604, 1828717938, 793248022, 90459833, 679018558, 262321, 1610760768, 543818312, 1320747069, 16924416, 1320747069, 840929856, 544800830, 282297, 1245734656, 11429654, 1728597497, 1611025913, 1611927594, 1308164156, 1308164156, 23076908, 13643584, 14962361, 1040203591, 22806732, 15474732, 22832674, -1301544606, 23219897, -1871773444, 963379552, 16404153, 1245734404, 1111506752, 304742574, 981616834, 1614967039, 14432956, 841744738, 792723676, 1925724800, 1712997359, 14700217, 575488495, 3981018, 14172015, 795803868, 16140399, 14173167, 14692396, 4033676, 14688261, -1516885432, 1320747068, 17850368, 637866026, 1061617940, 299591, 805576815, 1040215308, 1715527279, 1384471885, 13922258, -1100152828, 839328341, 18239126, 2080464910, 1043136516, 1826507334, 839331885, 1320876938, 271188142, 1610678132, -9549242, 604320303, 14307001, 1414482496, 16131119, 537218745, 1414482496, 4039642, -749705472, -466853888, -349427387, 22818629, 17196856, 1320747069, 23081479, 1320747069, 23212591, 1320747069, 15753228, 1957847044, -1165793530, -968474001, 271188145, 1728729920, 1729388574, -579324416, -2038693856, 3987882, 1983590403, 1728053588, 1728731456, 1610613066, 908918788, -1233354760, 1812614841, 1610613028, 1713778735, 1220562617, 1245734656, 793444616, 16661315, 808386820, 17834133, 278381, 1106182408, 808059428, -1478744504, 13023215, 604708975, 570957871, 3955242, 1106472960, 841941246, -759094775, -792211260, 3955242, 16916591, -792714232, 577700104, 544145672, 537415353, 1106472960, 16917103, 571023407, 3955242, 625476112, 1064239362, 1061421294, 1728503407, -1639698385, 963379552, 4027570, 15884314, 569864193, 898518713, 1065091073, 16016896, 15885824, 17065802, 625017398, 1111635266, 37364271, 35933881, 893387324, 1320747069, 37757487, 22817089, 23069026, 13642048, 36839983, 22816065, 960495968, 841941228, 35922479, 4027048, 960495970, 1320747069, 38561312, 1140391998, 282297, 1481589207, 4011406, 1289714936, 3679343, 1612720216, 1140861012, 1711806172, 383521280, 1861619737, -1869984545, 1223098424, 642408480, 1812218880, 8349192, 1611274459, 1241607926, 537628810, 1316309223, 608718521, 1111573056, 4056180, 1320747069, 1862271238, 577195705, 1207500862, 32909320, 537611961, -1199542524, 1111504896, 1320747069, 1245996608, 788874233, 1106837566, -15837105, 1104617480, -1453445097, 570433541, -1453412193, 1610760772, 570781705, -1519244728, 1731490306, 1320747069, -1300205820, 1111778842, 788537856, 4041054, 2013356034, 1245996552, -21729876, 1110114894, -1430631869, -1035763076, 541740729, -1849143623, 1320747069, 1289694264, 406347087, 4034976, 4041026, 24920569, 1320747069, 1104617480, -1450151420, 1979801602, 4105604, 1729118713, 1879133881, 1979796035, 32909320, 570695690, 4041104, 1979801602, 1711820473, 905988079, 1716417026, 4041104, 1711566849, 1430285364, 788537856, 537153209, -1331729404, 1111713300, 4070242, 458378938, 1111510713, 1245734656, 1610612866, 1912741899, -1450151422, 1979801602, 1734363715, 4128436, 570716169, -1464972736, 1610760771, 1879658169, 675815436, 1610760771, 1220554496, 1320747069, 1812231681, 1879232595, 34624132, -8626170, -1581628886, 4041402, 4022590, -1853727665, 1316309223, 608712704, -1851768255, 1320747069, 541740729, 1245736784, 582241977, 784092198, 1104617480, -1453428220, 805588665, 1320747069, 1863479815, 2125825, 4056180, 4022590, 68701813, 838910972, 4119166, 21636616, 671717507, 1320747069, 1862561793, 939527210, 1713654336, 1000, 537415353, -1329856512, 2013356034, 1289683992, 405819375, 939544249, 541740729, 1245734656, 1591407, 532554, -1523165105, 1140391998, 1320747069, 541806265, 1320870834, 4041026, 1912881623, 4041104, 1862563329, 211242022, 1106837566, 1320747069, 1245931016, 4007770, -1430613560, 1631481857, 1341063352, 1316309223, 1111706176, 1396717568, -1040448008, -629222208, 705184746, -1668996602, 4041104, 1879138306, 841613642, 172125530, -1267138497, 976814143, -633262023, -797376449, 1815360569, -733817750, 4131396, 172536901, 21934713, 1812738090, 4131400, 1320747068, 805588665, 805588666, 34228352, 1396729622, 1615088198, 1715220484, 1614039622, 1714171908, 1612991046, 1000, 537415353, -1329856512, 2080464898, 1289684088, 507009359, -1851768327, 1320747069, 4070388, 1105856261, -462146048, 1320747069, 1862271152, 1320747069, 1277561232, 537415353, 1912910464, 1610760772, 4119166, -1040448008, 208470015, 841745910, 4106152, 1610760770, 1105985680, 570826764, -1453409152, 1320877314, 1380301436, 1245996970, -1430631869, -1035763076, 1105856309, -462122552, 1631475791, 1316309223, 642269052, 2029997753, 1173946430, 121905227, -1532605888, 4117386, -1512683015, 541806265, 1245734656, 1320747069, 1862271294, 180763155, 537415353, 1912910464, 1610760774, 160458510, 1879133881, 2080457287, 209256454, 1811939566, 805814780, 13957, 638097037, 1320747069, 1862564865, 1716916269, 1061617668, 18946880, 9445965, 1320747069, 1106051216, -1471002048, 124407481, 805781997, 4019020, -1849143623, 805785273, 805785273, 914698247, 1320877224, 805785274, 1724813768, 1631465479, -1868674492, 1611812537, 1320747068, 1812004654, -1605744064, 1711688263, 914706105, 808386564, 1828994884, 290066, 1105985826, 1320747068, 1289698552, 524177391, 65768, 15091183, 1207500862, 1320747069, 514523328, -1507053760, 1320747069, -559218168, -1071370389, 1711550279, 13519855, 14043247, 14566383, 541871801, 1341063180, 841745148, -1874767040, 539951306, 1220628153, 570904249, 960496428, 13777216, 841679042, 159769, -1797897661, -448249351, 577765376, 805588665, 1380134915, 4070316, 1725177861, 67129017, 1056982009, 789147676, -1763561656, 1320747069, 1320747069, 4070272, 459808844, 1481588544, 37101679, 4057866, 1879761325, 1250256640, 1845952512, 959787315, 825373232, 892546080, 808727092, 909128761, 740307251, 825633824, 926494772, 892942134, 825702711, 909192224, 842283315, 892811063, 908861496, 943076917, 942682419, 740308016, 908861489, 926365750, 925971001, 540094517, 808466732, 825505590, 758200118, 909456940, 808924215, 540095282, 808859948, 808597298, 959983672, 540095544, 892613676, 808531511, 808793912, 825767737, 842345504, 842348086, 825766965, 825371680, 943141681, 842347319, 740309049, 808988716, 926037808, 959461681, 824975415, 926037297, 892744499, 540619318, 926034976, 875704627, 842348336, 740309296, 842150956, 842543923, 943272504, 858529849, 825506102, 858797878, 540619826, 825830432, 808988721, 808990774, 740309298, 926232620, 959918384, 892612656, 925638712, 909587250, 892678197, 540489016, 825764896, 892746036, 808991026, 740308276, 842543660, 943012153, 942684213, 942415929, 859191090, 808466741, 540555570, 926297120, 858862897, 808990521, 740309042, 926103340, 859059509, 942944819, 908861496, 909719093, 892548913, 540619827, 942746656, 876032817, 875574064, 740309040, 925972012, 808662840, 959789364, 824975416, 892612917, 909128503, 540555570, 960048160, 825832241, 842412083, 740309047, 909260588, 859060275, 926167091, 908861496, 809055542, 842347571, 540619827, 808725536, 842610740, 842347824, 740309045, 943142956, 909195576, 942814520, 841752632, 943141425, 943274288, 540488752, 959982624, 858928690, -767477198, 1220681730, -410503236, 805628232, 1106706448, 839207105, -729684086, 805654201, 1912680453, -1802883068, 12295, -1805225471, 4035722, 1106837566, 4039714, 1069350911, -1006893576, -629220671, 1828716858, 1828994562, 805627208, 1106837566, 274246, 839338177, -263179769, 771781120, 3974514, 1611968622, 808321028, 1220