| Re: [hatari-devel] mingw-w64 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] mingw-w64
- From: Christer Solskogen <christer.solskogen@xxxxxxxxx>
- Date: Sat, 21 Sep 2013 19:03:01 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=MroD5fKydQBtgyA0hhxXZgjLio2FtMHiERW3dreOakQ=; b=u14KqtHQTKqwuBFYVXZQtoRK4vxTYmexLTde0GTXeAwrSOJHVeGyGelF44LfP6u0dP DUy6Qk5QjpvHKZ1UMOyqmSA5ccGDj/19uDIg57+RxVYWnvgFU23KV39szT/WApl10D+d qzfrJA5H663g7JeJvErdCaolEOELkKoG1kRUIEzJjAse5rpntcD6Qyn7OGYr5e0nJYkp ErHEb9WM1M78iXfPfbVy02lxjopzqPbrQE9yAsRi7eCiazL76NCbdLWA8yYGJ2fAexwJ Oy7HShLsMoB8EjbrvIeLq7YH82/5AhBfdVGJXkbd6kNaRKyeCH3ztP12Yv1CHRydy72z d0cA==
On Sat, Sep 21, 2013 at 10:26 AM, Eero Tamminen <oak@xxxxxxxxxxxxxx> wrote:
> Redefining a variable seems bad practice to me.
>
Probably. But Toolchain-mingw32 already do that:
SET(CMAKE_FIND_ROOT_PATH ${CMAKE_FIND_ROOT_PATH}/mingw)
> What if such redefining is done in multiple places, and
> order of those happens to change?
>
Maybe in larger projects, but the Toolchain files for hatari is so
small that, that probably won't be any problem.
> I haven't looked into this at all, but what if you add variable for
> specifying compiler root path, in case it differs from standard one used
> by CMake, and document that for compilers needing it?
>
Well, with "my" cross compiler that should not be an issue, since both
the linker and compiler only searches for headers and libraries in the
defined $sysroot.
I happen to think that cmake tries to be smarter than the user, or in
this case the compiler.
--
chs,