| Re: [hatari-devel] configure does not check for zlib.h |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: Nicolas Pomarède <npomarede@xxxxxxxxxxxx>
- Subject: Re: [hatari-devel] configure does not check for zlib.h
- From: Christer Solskogen <christer.solskogen@xxxxxxxxx>
- Date: Wed, 30 May 2012 23:08:11 +0200
- Cc: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=zNcbkOutB3dAeADkY35JLzmTjZsCbEqc9f+G/tPTY24=; b=WL+nDckM8NV4y4UbWvJH5xZfQfCLP7SJt+Uw46W0sypXGmFJOSUaCzHHe+Baf+b8OK d4ZtC/Osi+YFyTVojo4fqCDOWUyZQkMnRNxSYRZKxjgfYxyTtA/j4o45S0sWDYFRY3ud LgKFXfW3kkP4gUvze/2Gym1ZkFr/YbTzED51tMrWlauE3BXWIsLQu/T1RuWJPN0tMmKP H8L7x5t2JcPowBr0N9WN5MZt2reQd0ld69n6MCEjtBPnpqYbexBUYqussiH+jSAJXSg3 PwN3DwNcwT4SSI6dSmqysjUrl2B8NrKihhXowU6EYH5+hlXaUNoL4qegsvQoRw0pH1G6 xerg==
On Wed, May 30, 2012 at 10:35 PM, Nicolas Pomarède
<npomarede@xxxxxxxxxxxx> wrote:
> On 30/05/2012 22:32, Christer Solskogen wrote:
>>
>> And I think it should, since without it compilation will fail.
>>
>>
>
> Hello
>
> are you sure ? In CMakelists.txt :
>
> find_package(ZLIB)
> if(ZLIB_FOUND)
> set(HAVE_LIBZ 1)
> set(HAVE_ZLIB_H 1)
> endif(ZLIB_FOUND)
>
Well, yes. It does check if it exist, you are right. But it will still
create a makefile.
I think configure should barf the same way it does when sdl.h is
missing. Since if zlib.h is missing you get this:
/home/solskogen/hatari/src/dim.c:11:18: fatal error: zlib.h: No such
file or directory
compilation terminated.
make[2]: *** [src/CMakeFiles/Floppy.dir/dim.c.o] Error 1
make[1]: *** [src/CMakeFiles/Floppy.dir/all] Error 2
make: *** [all] Error 2
--
chs,