Re: [hatari-devel] WinUAE core freeze with ST emulation, solved but another question about gemdos drive.

[Thomas Huth <th.huth@xxxxxx>]

Am Thu, 31 May 2012 23:32:15 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:

> Hi,
> 
> On tiistai 29 toukokuu 2012, Thomas Huth wrote:
> > Am Tue, 29 May 2012 00:00:07 +0300
> > schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > > On maanantai 28 toukokuu 2012, Eero Tamminen wrote:
> > > > Btw. Does your this patch:
> > > > http://hg.tuxfamily.org/mercurialroot/hatari/hatari/rev/a941332bd17b
> > > > 
> > > > make it unnecessary to turn cycle exact / compatible (prefetch)
> > > > options off for ST?
> > > 
> > > Tested it... No effect on that, one still needs to disable both
> > > options with ST.
> > 
> > After applying that patch, starting Hatari with "--cpu-exact 1"
> > worked for me. Which TOS version were you using? In case it also
> > does not work with different TOS versions, could you please mail me
> > your hatari.cfg?
> 
> I'm not anymore able to reproduce it, so I don't know how I actually
> got it...
> 
> So, what do you suggest to do with the patch?

diff -r f8b7da6c61de src/change.c
--- a/src/change.c	Thu May 31 23:00:07 2012 +0300
+++ b/src/change.c	Thu May 31 23:14:19 2012 +0300
@@ -119,13 +119,17 @@
 	/* Did change CPU prefetch mode? */
-	if (changed->System.bCompatibleCpu != current->System.bCompatibleCpu)
+	if (changed->System.bPrefetchCpu != current->System.bPrefetchCpu)
 		return true;

That should not be necessary. One should be able to change between the
prefetch/non-prefetch and cycle-exact/non-cycle-exact modes without
reset. If that does not work yet, you should rather fix the WinUAE core
accordingly instead of forcing a reset here.

Also, I don't like the idea of renaming that option from "compatible
cpu" to "prefetch cpu" because of
a) it's also named "cpu_compatible" in the WinUAE core
b) it's not only about enabling prefetch in the CPU core, but also some
   other things if I remember clearly (e.g. address error emulation).
So could you please keep the old name?

 Thomas