[gluon] Fwd: Gluon: gamesmodel

---------- Forwarded message ----------
From: Shantanu Tushar Jha <jhahoneyk@xxxxxxxxx>
Date: Sun, Feb 6, 2011 at 5:19 PM
Subject: Re: Gluon: gamesmodel
To: Laszlo Papp <djszapi@xxxxxxxxxxxx>

Um, is it really a good idea to do something UI specific in a model (storing and returning a widget in the model) ?
Imo model should only be concerned about the data.

On Sun, Feb 6, 2011 at 4:00 PM, Laszlo Papp <djszapi@xxxxxxxxxxxx> wrote:

Hi,

I was thinking further on, a new model for the kde standalone player
would be more appreciate because this new widget is heavily KDE
specific and that should not be used in QML, Qt, Plasma player at all.

Unfortunately, I cannot inherit your model implementation because it
contains two basic methods you had to reimplement that I also need to
reimplement. (But this also means that there is no code duplication)

All in all, I would go with this idea further on. Approve or objection to ?

Best Regards,
Laszlo Papp

On Sun, Feb 6, 2011 at 11:03 AM, Laszlo Papp <djszapi@xxxxxxxxxxxx> wrote:
> Hi Shaan7,
>
> Can we add a new gamesviewitem member to this model and a new item
> data role to return it ? It would be much better for the update widget
> of the relevant KDE class.
> It is better to construct those widgets one time and return them
> instead of the relevant data and construct all the xxxx+ in the update
> widget method. It would be a performance bottleneck compared to the
> widget storage. (We should also add a setter for addition to the new
> QList <GamesViewItem> m_viewitems; member for sure)
>
> This addition would not break anything about the plasmoid because it
> is just called after a new custom item data role. The same happens
> with ghns, by the way.
>
> Best Regards,
> Laszlo Papp
>

Shantanu Tushar (UTC +0530)
http://www.shantanutushar.com