[gluon] Re: Review Request: Reload the Assets when their file changes.

[ Thread Index | Date Index | More lists.tuxfamily.org/gluon Archives ]


This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100445/

Ship it!

I think it's fine like this. Please merge the branch to master with a commit message saying REVIEW 100445 .

- Arjen


On January 27th, 2011, 10:49 a.m., Giulio Camuffo wrote:

Review request for Gluon.
By Giulio Camuffo.

Updated Jan. 27, 2011, 10:49 a.m.

Description

This patch makes Creator watch the files of the Assets for changes with a KDirWatch. If a file changes it calls reload() on the respective Asset.
It also modifies some code in graphics to support this (that is, do not return if it was already loaded but instead discard and load again), but there will probably be the need to do the same in Input and Audio.

Testing

Tested modifying a material .gml and a texture image.

Diffs

  • creator/lib/models/projectmodel.cpp (a082fa2)
  • creator/lib/objectmanager.h (90c68a6)
  • creator/lib/objectmanager.cpp (a088c80)
  • creator/mainwindow.cpp (ec9fc2e)
  • creator/plugins/docks/projectdock/projectdock.cpp (382ace5)
  • engine/asset.h (5d3a126)
  • engine/asset.cpp (e134db2)
  • graphics/material.cpp (9e1a040)
  • graphics/texture.cpp (00fe36d)

View Diff



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/