Re: [fusil] [PATCH] Add -i option for displaying the instruction pointer

[ Thread Index | Date Index | More lists.tuxfamily.org/fusil Archives ]


Victor Stinner <victor.stinner@xxxxxxxxxxxxx> wrote:

> >          if self.options.show_pid:
> > -            text = "[%s] %s" % (syscall.process.pid, text)
> > +            text = "[pid %s] %s" % (syscall.process.pid, text)
> >          error(text)
>
> Why did you add "pid " prefix?  I prefer to keep a short prefix.

To distinguish it from the instruction pointer and for consistency
with regular strace.  But I don't have a strong preference.

Cheers,
Mark



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/