Re: [eigen] Should we require c++11 for Eigen tensor

[ Thread Index | Date Index | More Archives ]


I think some time ago there was some opposition against that step -- in fact, originally C++03 was only introduced after the first versions of the Tensor module.

I can't find a reference to that discussion at the moment, I think it concerned supporting Tensor for some GPU architecture. But this was a few years ago, and compilers likely evolved since then.

So unless there is an outcry on this list, I'm not against dropping C++03 support of the Tensor module.

For transitioning it would of course be nice to have a clear "latest working" version which still supports C++03, one possibility would be to make that with the 3.4 release. OTOH, this will just complicate maintenance and Tensors are still "unsupported" for a reason (e.g., not having to spend unnecessary time to support them ...)

So just making a clear cut before 3.4 sounds actually better -- this will also simplify to maintain the upcoming 3.4 and master versions in parallel (I guess the 3.3.x version of the Tensor module has barely been touched in recent years).


On 18/10/2019 18.46, Rasmus Munk Larsen wrote:
Dear Eigen tensor users,

Today, various c++11 features are in use in many parts of Eigen tensor,
while other parts compile with c++03 without warnings. This division is
rather arbitrary and primarily dictated by what parts of the code gets
compiled for the subset of tests that are enabled in c++03 mode:

A larger set of tests covering the majority of the code base are only
compiled in c++11 mode:

I don't think a user can realistically use Eigen tensor and avoid the c++11
parts of the code. Therefore I would propose that we stop pretending that
Eigen tensor supports c++03 and simply guard all the code with
EIGEN_HAS_CXX11 or similar. This will then allow us to start cleaning up
the code.

Please let me know if you have any objections to this.


 Dr.-Ing. Christoph Hertzberg

 Besuchsadresse der Nebengeschäftsstelle:
 Robotics Innovation Center
 Robert-Hooke-Straße 5
 28359 Bremen, Germany

 Postadresse der Hauptgeschäftsstelle Standort Bremen:
 Robotics Innovation Center
 Robert-Hooke-Straße 1
 28359 Bremen, Germany

 Tel.:     +49 421 178 45-4021
 Zentrale: +49 421 178 45-0
 E-Mail:   christoph.hertzberg@xxxxxxx

 Weitere Informationen:
  Deutsches Forschungszentrum für Künstliche Intelligenz GmbH
  Trippstadter Strasse 122, D-67663 Kaiserslautern, Germany

  Prof. Dr. Jana Koehler (Vorsitzende)
  Dr. Walter Olthoff

  Vorsitzender des Aufsichtsrats:
  Prof. Dr. h.c. Hans A. Aukes
  Amtsgericht Kaiserslautern, HRB 2313

Mail converted by MHonArc 2.6.19+