[eigen] Should we require c++11 for Eigen tensor |

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

*To*: eigen <eigen@xxxxxxxxxxxxxxxxxxx>*Subject*: [eigen] Should we require c++11 for Eigen tensor*From*: Rasmus Munk Larsen <rmlarsen@xxxxxxxxxx>*Date*: Fri, 18 Oct 2019 09:46:59 -0700*Dkim-signature*: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=b6r4RoYPR6bFE4deFX0B5g10Evauz4PLwaVnNVIaeXw=; b=klI3Dlh1F79Fw3gBHgrjjy3KZ4VBTQlZUyjlVtnt7/GSBF7IzvqeteEE74PMis+5UA q16Mf16wL9fGFizgb1k7Lx0i4/3g5O1NQt8j3wThYEBnpYv/z3oomL+3TRPjZJtI7Lk/ rcNpF1hTSqNwwvM2YlgYT6gi8nyoZT/QpLQs0N72doKX3Oe/f1SkG+ejet2JmkptciN8 VMth1y7yNKGHGvwPNrKnRZIGEE8UgTaoCvFH4SBxWQSko/qSFbZRNLRSOmDeoJ41qN1O z4zlP45ciZieowshgP/rmVkye4cpNMSNlUZeYMK2RSoPNCWDfJoVy2Jl0P72vdcCU4y7 yaFA==

Dear Eigen tensor users,

Today, various c++11 features are in use in many parts of Eigen tensor, while other parts compile with c++03 without warnings. This division is rather arbitrary and primarily dictated by what parts of the code gets compiled for the subset of tests that are enabled in c++03 mode:

https://bitbucket.org/eigen/eigen/src/default/unsupported/test/CMakeLists.txt#lines-112

A larger set of tests covering the majority of the code base are only compiled in c++11 mode:

https://bitbucket.org/eigen/eigen/src/c4368f48fef3737ef5a48604cfc63ce946b68616/unsupported/test/CMakeLists.txt#lines-179

I don't think a user can realistically use Eigen tensor and avoid the c++11 parts of the code. Therefore I would propose that we stop pretending that Eigen tensor supports c++03 and simply guard all the code with EIGEN_HAS_CXX11 or similar. This will then allow us to start cleaning up the code.

Please let me know if you have any objections to this.

Best,

Rasmus

Today, various c++11 features are in use in many parts of Eigen tensor, while other parts compile with c++03 without warnings. This division is rather arbitrary and primarily dictated by what parts of the code gets compiled for the subset of tests that are enabled in c++03 mode:

https://bitbucket.org/eigen/eigen/src/default/unsupported/test/CMakeLists.txt#lines-112

A larger set of tests covering the majority of the code base are only compiled in c++11 mode:

https://bitbucket.org/eigen/eigen/src/c4368f48fef3737ef5a48604cfc63ce946b68616/unsupported/test/CMakeLists.txt#lines-179

I don't think a user can realistically use Eigen tensor and avoid the c++11 parts of the code. Therefore I would propose that we stop pretending that Eigen tensor supports c++03 and simply guard all the code with EIGEN_HAS_CXX11 or similar. This will then allow us to start cleaning up the code.

Please let me know if you have any objections to this.

Best,

Rasmus

**Follow-Ups**:**Re: [eigen] Should we require c++11 for Eigen tensor***From:*Christoph Hertzberg

**Messages sorted by:**[ date | thread ]- Prev by Date:
**[eigen] Assignment to a TensorRef<Tensor<std::complex<float>, 2>>?** - Next by Date:
**Re: [eigen] Should we require c++11 for Eigen tensor** - Previous by thread:
**[eigen] Assignment to a TensorRef<Tensor<std::complex<float>, 2>>?** - Next by thread:
**Re: [eigen] Should we require c++11 for Eigen tensor**

Mail converted by MHonArc 2.6.19+ | http://listengine.tuxfamily.org/ |