Re: [eigen] 3.2.3 for the end of the week.

If you are taking out warnings there is also:

2>e:\libraries\eigen\eigen-3.2.3\eigen\src/Core/ProductBase.h(91): warning C4308: negative integral constant converted to unsigned type

2> e:\libraries\eigen\eigen-3.2.3\eigen\src/SparseCore/SparseDenseProduct.h(260) : see reference to class template instantiation 'Eigen::ProductBase<Derived,Lhs,Rhs>' being compiled

2>e:\libraries\eigen\eigen-3.2.3\eigen\src/Core/ProductBase.h(91): warning C4307: '*' : integral constant overflow

2>e:\libraries\eigen\eigen-3.2.3\eigen\src/Core/ProductBase.h(91): warning C4308: negative integral constant converted to unsigned type

All the same line of code.

Regards,

Billy.

On Fri, Dec 12, 2014 at 11:14 AM, Christoph Hertzberg <chtz@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:

On 11.12.2014 21:51, Ryan Pavlik wrote:

In addition to the aforementioned unused typedef, I've hit this warning,
with MSVC 12 and warnings cranked up:

eigen\src/Geometry/Transform.h(233): warning C4127: conditional _expression_
is constant

Currently working around it by using a header to push and pop warning state
when including eigen.

We could add that to our DisableStupidWarnings header.

Also, there's no mention of Isometry as a mode in the Geometry/Transform
docs. That's probably not necessary to try to squeeze in a release, since I
use the docs on the web site anyway...

Isometry is "mentioned" (but not documented) here:
http://eigen.tuxfamily.org/dox/group__Geometry__Module.html

Generally, documentation can be improved at lots of places, but that should not block 3.2.3

Other than that, I pushed some small changes to fix the remaining gcc/clang warnings. There are some unit tests constantly failing
* minres_1
* levenberg_marquardt
* openglsupport
* mpreal_support (passes when compiled with clang, however)

And some are occasionally/frequently failing.
However, none if that is critical, IMO.
So I won't object releasing (perhaps with the above mentioned suppression)

Christoph

--
----------------------------------------------
Dipl.-Inf., Dipl.-Math. Christoph Hertzberg
Cartesium 0.049
Universität Bremen
Enrique-Schmidt-Straße 5
28359 Bremen

Tel: +49 (421) 218-64252
----------------------------------------------