Re: [eigen] latest default changeset (e8aee247f42a) causes compiler error on MSC

[Gael Guennebaud <gael.guennebaud@xxxxxxxxx>]

On Tue, Dec 2, 2014 at 11:01 PM, Eamon Nerbonne <eamon@xxxxxxxxxxxx> wrote:

Sorry about the late reply - but yes, that works fine!

Already pushed!

 

Incidentally, is AVX currently supposed to work on the default head?  I haven't dived into details yet, but I'm what looks like corrupted data even in fairly trivial operations.  If that's WIP, I'll wait, otherwise I could try and extract a test-case.

Yes AVX is supposed to work fine, but it is not enabled by default. You have to enable AVX on your compiler (e.g., -mavx with gcc/clang/icc). A self-contained test-case would be very welcome then.

gael

 

Thanks for the fix (and Eigen :-)),

--Eamon

--eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163

On Sun, Nov 30, 2014 at 9:31 PM, Gael Guennebaud <gael.guennebaud@xxxxxxxxx> wrote:

Hi,

thank you for the notice. Could you confirm that the attached patch works for you?

Thanks

Gael

On Sat, Nov 29, 2014 at 5:44 PM, Eamon Nerbonne <eamon@xxxxxxxxxxxx> wrote:

Hi all,

Two of my Eigen-using programs currently fail to compile on MSC (Visual Studio 2013 update 4) with the following message:

1>c:\vcs\external\eigen\eigen\src/Core/Diagonal.h(225): error C2373: 'Eigen::MatrixBase<Derived>::diagonal' : redefinition; different type modifiers
1>          c:\vcs\external\eigen\eigen\src/Core/MatrixBase.h(254) : see declaration of 'Eigen::MatrixBase<Derived>::diagonal'

The error does not occur on 31d2b16f5ef1, but does on the changeset immediately thereafter (e8aee247f42a: Simplify return type of diagonal(Index) (and ease compiler job)).

--Eamon

--eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163