Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
Date: Mon, 16 Jun 2014 15:31:17 +0200
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=4WUDGKC8p+2tt99lPQKFI2yxW0Q2waICzNIx+EoP7aI=; b=BXiHilmn9n/+j8jd01fEUZxRJ6dEBGrMZw7ExpRVXUQMaubnGSzQhjCTF+fCwsMWI6 QKy8sa4UyNO06hwcmVw1ZKK2UfGSg/ep4A885zTnppKwhg2vtRJcdHLyVCHzvplRC9VU gtj9lUD9Peeab1nY8WOEjZIUZqwDuq3jNCm2DRHxLJFTJNLdLr8Uv6hf2aO9/tjIi8gD ZKziL9icCwnpKFMbId0WcsPhgSguL/jnpeBSOzqUhcraJmzhXjcsfOsGDIWAB9czX8TL C6q+KsWAiCbHTQaoSiRbPd1GIw8CP/6jxZOS12nQTXcSdpZVQMbCBsyWJOXmRoJbjcp6 OI/Q==

On Mon, Jun 16, 2014 at 11:51 AM, Christian Seiler <christian@xxxxxxxx> wrote:

I generally like your new names, but I don't think I can reuse
DenseBase at the moment as a base class, since EigenBase,
DenseCoeffsBase and DenseBase currently only support two indices.
That's why I suggested copying but not reusing Eigen's own class
hierarchy.

I don't see why this is a problem: MultiDimBase would add the needed multi-dim accessor overloads.

gael

Follow-Ups:
- Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Christian Seiler

References:
- [eigen] [RFC] Tensor module: class hierarchy
  - From: Christian Seiler
- Re: [eigen] [RFC] Tensor module: class hierarchy
  - From: Benoit Steiner
- [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Christian Seiler
- Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Benoit Steiner
- Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Christian Seiler
- Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Benoit Steiner
- Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Christian Seiler
- Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Gael Guennebaud
- Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
  - From: Christian Seiler

Messages sorted by: [ date | thread ]
Prev by Date: [eigen] Matrix multiplication seems to be exceptionally slow in one specific case
Next by Date: Re: [eigen] Matrix multiplication seems to be exceptionally slow in one specific case
Previous by thread: Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements
Next by thread: Re: [eigen] [Review] Pull request 66, Huge Tensor module improvements

Mail converted by MHonArc 2.6.19+

http://listengine.tuxfamily.org/