| Re: [eigen] Developer Contribution Style and Technique |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Developer Contribution Style and Technique
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Thu, 20 Sep 2012 09:29:04 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=xXGo1BaQnJMCGbxP0o7a20DAi32ciDZuoQcvuEB6FI8=; b=iv4r+pr7i3kDbQCxysHq0RlDy+yvEcQU1zhPa7dFYTdcxPzgtJKfF8+D+MJ/+yxqbG c72SvMb0sSKXO9Emipki83QDV8XEC430LDbqrUCekqwTi2Op063aw8VjzFsDhtfqxBR4 pQir/PC25oRbH5uvWu3aXTfDw+ud8ZtrR8LTa84FSClrD/kuEXqEvLlI7D9+d+0x/uAJ GE6oVt9w4nrDBOWo0LR71R8It1fz6VSWmByo4awxdwHOafBlDdhwVAN5dyRDeGY9L7Cn VxO4uE+Ar7lHu97y0Z8OMM8kzIOh0ghgk1JUTTjPpT53phWQT5mEKY3Mk8tyP8RhYOxH g/Lw==
Hi,
this page links to several ressources for developers:
http://eigen.tuxfamily.org/index.php?title=Category:Developer
In particular, there is a few coding rules there:
http://eigen.tuxfamily.org/index.php?title=Developer%27s_Corner#Eigen_hacking
Eigen's repository is not open for writing, so the best is open an
entry in our bug tracker for feature you start working on, and upload
patches there that we can review and push once it is ready.
This page will guide you for producing the patches using mercurial:
http://eigen.tuxfamily.org/index.php?title=Mercurial.
Regarding openmp support for sparse products, I have some local
changes doing so. However, on modern computers with NUMA, to achieve
good speedup, the data should ideally be split and copied into the
right memory location prior to the matrix products. This of course
only makes sense when a given matrix is used several times, so
typically for iterative solvers. It is not clear to me yet how to
design such a behavior though.
Regarding, "a broader range of interfaces to external linear solver
packages", could you be more specific about the libs you have in mind?
cheers,
Gael
On Wed, Sep 19, 2012 at 9:21 PM, Cowing-Zitron, Christopher
<ccowingzitron@xxxxxxxx> wrote:
> Hello,
>
> My name is Chris Cowing-Zitron. I work in bioninformatics at the University
> of California, San Diego. I'd like to contribute to the development of
> Eigen; a few of my ideas are adding openmp support for sparse products,
> adding a broader range of interfaces to external linear solver packages, and
> possibly adding basic data transfer support from Fortran via the map class.
> I do have two concerns though: Eigen uses such powerful C++ metaprogramming
> methods that I'm worried I might inadvertently mess something up (though of
> course I wouldn't submit any code until I was sure it compiled correctly),
> and also I don't want anyone to have to clean up my code to fit Eigen design
> and style standards. Is there any resource that I've missed that describes
> the standards for submission to Eigen? Or perhaps an archived email from the
> lists that covers this question? Thanks for your help, and thanks for Eigen.
>
> -- Chris