| Re: [eigen] Submission of two patches for Eigen 3 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Submission of two patches for Eigen 3
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Mon, 17 Jan 2011 10:00:10 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=HVnsPQVMZVQpHyUjBCkVmuQs1BDjKLhRm5WUc+By+N0=; b=he+J8B92TVAxEFya82XuCvVEJGCc7FbETySg7gBwnQfhpGnDkUlEPOHO9u1vbY5zIU O5rIGrPylnigpliGSbd1tnsQyLH5rYeYwSq18yGy4HPfsfS3Stg1dX2vWRcqEcGcgHEK hJM4LzQGi6BjGJSXV20pE7RuGqN5kWYdQI1hw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Pwwyp2P5Am6Z6XqAwCyPPSt7VvQAlWdOOaWln+Gs1l8GflKApzAAlmRkQa7/119JVS RFTpYbvAuyiO+RPhqRdSIo0n7ZoitRUihndqeJ9GSqRnL8hxw599OPJB8IbyfPVbW9Ev QqKNYIeYYdKtnPaioHzY5eSJaoVzdsM8Nt7tc=
pushed
2011/1/14 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> I'll review it ASAP: it's a good idea.
>
> 2011/1/14 <hamelin.philippe@xxxxxxx>:
>> Thank you for adding this patch. Who is intended to make the decision for
>> the second patch?
>>
>> Philippe
>>
>> ________________________________
>> De : Thomas Capricelli [mailto:orzel@xxxxxxxxxxxxxxx]
>> Envoyé : 14 janvier 2011 08:30
>> À : eigen@xxxxxxxxxxxxxxxxxxx
>> Cc : Hamelin, Philippe
>> Objet : Re: [eigen] Submission of two patches for Eigen 3
>>
>> I dont know for the source-dir-scoping.
>>
>> But indeed, Qt stuff was broken. I've committed a slightly different fix..
>>
>> Thomas
>>
>> --
>>
>> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>>
>> http://www.freehackers.org/thomas
>>
>> On Thursday 13 January 2011 19:39:10 hamelin.philippe@xxxxxxx wrote:
>>
>>> Hello,
>>
>>>
>>
>>> it would be great if these two patches could be applied on the master
>>> branch of Eigen 3:
>>
>>>
>>
>>> 1. fix-cmake-qt-tests.patch : Fix compilation error of tests when Qt4 is
>>> found.
>>
>>>
>>
>>> 2. project-source-dir-scoping.patch : Replace CMAKE_SOURCE_DIR with
>>> PROJECT_SOURCE_DIR to allow the cmake project to be included by a root
>>> project.
>>
>>>
>>
>>> Thank you,
>>
>>>
>>
>>> ------------------------------------
>>
>>> Philippe Hamelin, ing. jr, M. Ing
>>
>>> Chercheur / Researcher
>>
>>>
>>
>>> T: 450-652-8499 x2198
>>
>>> F: 450-652-1316
>>
>>>
>>
>>> Expertise robotique et civil
>>
>>> Institut de recherche d'Hydro-Québec (IREQ)
>>
>>> 1740, boul. Lionel-Boulet
>>
>>> Varennes (QC) J3X 1S1, Canada
>>
>>>
>>
>>>
>>
>>>
>