Re: [eigen] [Sparse] bugfix

[ Thread Index | Date Index | More Archives ]

thanks for the patches. applied, cleaned, and pushed.


On Thu, Dec 30, 2010 at 3:25 PM, David Luitz <tux008@xxxxxxxxxxxxxx> wrote:
> Me again,
> I have another fix for a bug in the sparse module, same place as before in
> the file Eigen/src/Sparse/SparseDenseProduct.h.
> In the class SparseTimeDenseProduct, we use a Block constructor, which does
> not compile in certain cases.
> Block<Dest,1,Dest::ColsAtCompileTime> dest_j(dest.row(LhsIsRowMajor ? j :
> 0))
> I changed it to
> Block<Dest,1,Dest::ColsAtCompileTime> dest_j(dest, LhsIsRowMajor ? j : 0);
> and this seems to work now. I added a unit test sparse_product_4, which
> fails to compile with the old code and works fine with the new code. The
> test also checks for the Sparse bug I reported before and produces a
> segfault (at least on my machine) for the old code, while it works with my
> patch.
> I commited all these changes including my previous patch to mercurial and
> exported them using hg export.
> You will find 3 commits in the appended patch file.
> Greetings,
> David Luitz

Mail converted by MHonArc 2.6.19+