| Re: [eigen] patches for eigen3.0-beta2 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] patches for eigen3.0-beta2
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Mon, 27 Sep 2010 10:03:43 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=KB9Ifp6LmMJBW8XzKyxCUkURl/YfLy9vCIYDR4ELjYo=; b=C4XMi9Q6jKIpFQyqZW7ipkoo5OlTFCrQ189erRx/aL+47lyBYjTcV5wadGIodR1ERx K8p4WyhoNO7CggzmaEL7sWhTTmuzn+HTbjmTTMPG8CvYUprf6GwPQ4ms6HQa6uCUlsRk dgX0x1bbka4w5oafowxOTww7vj5fQLTnAfl4U=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=lJyNaEiNuAL2K7Z5uabU6VLpc3PdMo4ioNjIRLMTlubFSqCBwP25a9RuiwuM6fvseO OINW3wHn4RX1f/WStUrg6AFWr0POd5H6/XCqdIjPQdsKjxpafNjSdRSYgc6KnKnmkIBI mkIS8D4ZKIqxDCuuAjWasNRAZyY5nC8W/CKNI=
ok, i'm pushing the warning and the compilation patches as soon as
unit tests finish. turned your warning patch into a changeset in your
name.
But for the tridiagonalization patch, it seems to me that these
changes have already been pushed by Gael on July 16. Right?
Benoit
2010/9/27 Radu Bogdan Rusu <rusu@xxxxxxxxxxxxxxxx>:
>
> In an attempt to clean up the ROS eigen3 meta package, I was wondering if we
> can integrate the following 3 patches into Eigen trunk, such that when beta2
> comes out we don't have to apply them in ROS.
>
> These are:
>
> * tridiag_3x3.patch: patch provided by Gael that fixes the float eigen
> decomposition precision (without it MatrixXd matrices work well but MatrixXf
> ones do not)
>
> * gcc43.patch: patch provided by Benoit that makes GCC 4.3 on Ubuntu 9.04
> happy (without it Eigen3 fails to compile)
>
> * warning.patch: patch that silences a compilation warning in Ubuntu 10.04
>
>
> Thanks a lot in advance!
>
> Cheers,
> Radu.
>
>