Re: [eigen] Feature suggestion: interior row and column ranges [patch attached]

[Benoit Jacob <jacob.benoit.1@xxxxxxxxx>]

Hi,

1) no need to attach the .out, they're automatically generated by CMake.
2) instead of attaching new .cpp files, please "hg add" them and
generate a diff as usual (hg commit, hg export tip).

Benoit

2010/6/29 Manoj Rajagopalan <rmanoj@xxxxxxxxx>:
>
> Hi all,
>
> Attachments:
> 1. patch with {row,col}Range() renamed to middle{Rows,Cols}() and updated
> test-case file
> 2. Example files referred to in the Doxygen documentation
> 3. Corresponding sample output files
>
> Notes:
> The Doxygen comments in Block.h refer to MatrixBase_*.cpp as the example
> files. I think these should be renamed to DenseBase_*.cpp. So far I have
> followed the existing nomenclature in my patch. I am guessing that at the
> right time one of the maintainers will run a script to make this correction.
>
> thanks,
> Manoj
>
>
>
>
> On Tuesday 29 June 2010 01:39:57 pm Gael Guennebaud wrote:
>> you can export a range of commit this way:
>>
>> hg export rev_start:rev_end,
>>
>> e.g.:
>>
>> hg export 3090:tip
>>
>> gael
>>
>> On Tue, Jun 29, 2010 at 6:50 PM, Manoj Rajagopalan <rmanoj@xxxxxxxxx> wrote:
>> > I made the changes and performed a local commit without rollback on the
>> > previous local commit. Now the hg export tip > diff-file stores only the
>> > diff with respect to the last local commit and not with respect to the
>> > file-versions in the hg repo.
>> >
>> > How do I fix this problem? I performed one rollback (after making a copy
>> > of the latest file with all desirable changes) and I got back the file
>> > with rowRange() instead of middleRows(). Now I need to replace this with
>> > the file in the repo. "hg revert DenseBase.h" doesn't seem to have any
>> > effect.
>> >
>> > thanks,
>> > Manoj
>> >
>> > On Sunday 27 June 2010 12:25:31 pm Benoit Jacob wrote:
>> >> 2010/6/27 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
>> >> > 2010/6/27 Manoj Rajagopalan <rmanoj@xxxxxxxxx>:
>> >> >> Do you want me to resend the patch with the new names - middleRows()
>> >> >> and middleCols()?
>> >> >
>> >> > Yes please and also make sure to indent with spaces, not tabs, in
>> >> > DenseBase.h
>> >>
>> >> Also please update test/corners.cpp to test all your new functions.
>> >> And yes, that filename becomes not so good anymore, but let's take
>> >> care of that later.
>> >>
>> >> Benoit
>> >>
>> >> > Benoit
>> >> >
>> >> >> Thanks,
>> >> >> Manoj
>
>