| Re: [eigen] beta1: Nullary tests failing |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] beta1: Nullary tests failing
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Wed, 30 Jun 2010 13:58:56 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=VgV/KtTpflvzcyagC/rhEXRNA+r0E9sy4pYgUf9Ewio=; b=LUL5N2dYgJq51rYHFF1JYMQq3khdZnCSuhRpOK8AhWaxBjLUg01/aCbxBwE769gvox PnMIv/sWa7hXmohAUq761frX/Ux48XS/abXSspeKh13vdYGgngT2TFzCloUOkheKj1Lg nDqfxUwWJZ4dJj+IO/4l42RwRqw5/zNjvTdCI=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=xnY8PGYmfp/Z4lCQy2HmYHgc6uF51egTXnwhDA3HMMXSfQGDHuHQzuUGggyCQuom2n OBWKEcn3whZ7j/Vkeywd3M9Lx9tZK+mlGcD6Me+lJRvOOEVbuiDNYd1rVhTHBLM2U+IL gUBGyigVbIHPZQZzaxJtOClWaLzC2yTpxZ4wA=
2010/6/30 Carlos Becker <carlosbecker@xxxxxxxxx>:
> On Wed, Jun 30, 2010 at 6:45 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
> wrote:
>>
>> 2010/6/30 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
>> Try this:
>>
>> replace this line,
>> VERIFY( (row_vector-col_vector.transpose()).norm() <
>> NumTraits<Scalar>::epsilon() );
>>
>> by this:
>> VERIFY( row_vector.isApprox(col_vector.transpose(),
>> NumTraits<Scalar>::epsilon()));
>>
>> this does a relative fuzzy check.
>>
>
> Ok this works fine and the tests pass. Should I push this change, or maybe
> wait for Hauke's opinion ?
You can push, this is a safe change. epsilon only is meaningful for
relative comparisons.
Benoit