yes, I agree such construction method can be quite convenient.
On Fri, Jun 18, 2010 at 9:50 AM, Sameer Agarwal
> Dear Eigen Folks,
> Keir and I are quite interested in Eigen having world class sparse matrix
> support. We spent some time talking about it and here are some thoughts.
> Some of this stuff is from my previous email on the subject.
> 1. Construction.
> Eigen should support a (i,j,s) triplet based constructors of the form
> SparseMatrix* M = BuildSparseMatrix( vector<int> rows, vector<int> cols,
> vector<double> values, int num_rows, int num_cols);
> SparseMatrix* M = BuildSparseMatrix( int* rows, int* cols, double* values,
> int nnz, int num_rows, int num_cols);
> I think this a much more useful way of building a sparse matrix rather than
> the DynamicSparseMatrix route.
Regarding the API, maybe it would be better to directly have
SparseMatrix constructors taking a list of Triplet as follow:
SparseMatrix(Index rows, Index cols, const TripletIterator& begin,
const TripletIterator& end);
Where typeof(*TripletIterator) must provide the rowId(), columnId(),
and value() functions (or whatever other names if you don't like
them). Of course we would provide a default template Triplet class.
Here TripletIterator could be std::vector<Triplet>::iterator, Triplet*, etc....
Do you really want to be able to use three different buffers ?
> 2. BLAS
> We should first focus on building a sparse BLAS, but we don't actually need
> the whole thing.
> The most common operations that we should focus on are
> vector * scalar
> vector / scalar
not available and I'm not sure it makes sense because theoretically
> vector + scalar (maybe)
> vector - scalar (maybe)
that means all zeros become equal to the scalar, and so the matrix
become dense. Maybe we could offer a method to return the list of non
zeros as an Eigen dense vector, so that the user can do all kind of
low level operations on these values.
OK for norm() and squaredNorm(), have to add other p norms
> vector.norm() (all p norms)
> vector +/- vector
> dot(vector, vector)
> Matrix * vector
> Matrix^T * vector
yes, I've checked a few recent paper on that topic, but it seems the
> If we have well optimized robust implementations of these operations, a
> majority of sparse matrix usage will be satisfied. In particular it gives us
> enough operators to build iterative solvers with. Which brings up the issue
> of efficient implementation of SpMV - sparse matrix dense vector product.
> This is the source of much activity in the high performance computing
> lately, and a naive implementation of spmv has extremely poor performance.
> It is hard to hard code a strategy that works well for all matrices.
> One direction we could look into is wrapping the OSKI library
only way to really speed up thing is through an analysis of the sparse
matrix which is often as expensive than the product itself, and so the
only situation to get significant speed up is when the spmv product is
performed multiple times on a matrix having the same nonzero pattern.
Nevertheless, I'll bench oski.
This is definitely a must to have, and this is also a good way to test
> 3. Iterative Methods
> A library of sparse iterative solvers built on top of the sparse matrix
> support. This may or may not be part of Eigen proper. A very useful thing to
> have here are implementations of a variety of basic preconditioning schemes.
> Not just for square/symmetric systems but also for rectangular systems and
> non-symmetric systems.
the basic API is fine. Recently, Daniel Lowengrub kindly proposed his
help to improve the Sparse module, and I oriented him to this
Yes, and we also need a better way to declare and instantiate the
> 4. Direct methods
> Here we need better support for exposing the interface to symbolic
> factorization reuse, and the various ordering options that solvers provide.
solvers because the current proposal is not really scalable and error
prone. The API should also minimize the need of temporaries. As you
said earlier, people can already do their own cooking to use Eigen's
SparseMatrix with such libraries, and so this part is less critical
and it can be delayed for 3.1.
That's great :) With the addition of Daniel Lowengrub we should have
> Both Keir and I are interested in helping with this.
enough man power to get it right :)