Re: [eigen] [patch] LDLt decomposition with rank-deficient matrices

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]


2010/6/20 Gael Guennebaud <gael.guennebaud@xxxxxxxxx>:
> On Sun, Jun 20, 2010 at 10:54 PM, Ben Goodrich <bgokgm@xxxxxxxxxxxxxx> wrote:
>> On Thu, Jun 17, 2010 at 4:00 PM, Gael Guennebaud
>> <gael.guennebaud@xxxxxxxxx> wrote:
>>> hm, on the other hand for other decompositions (e.g., QR) we have
>>> separate classes, so maybe it makes sense to have a separate class as
>>> well ? (they can possibly share the same implementation)
>>>
>>> gael
>>
>> It does not make too much difference to me whether there are separate
>> classes. Would it be sufficient to just add a flag to the class
>> definition, so that the methods could verify whether the decomposition
>> used pivoting or not?
>
> yes, it's just a matter of consistency over Eigen's API.
>
> Benoit, do you have an opinion ?

I have a very slight preference for different class names, since as
you mention, this is what we have in other decs.

No strong opinion :)

Benoit


>
> gael
>
>>
>> Ben
>>
>>
>>
>
>
>



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/