[eigen] about eebce0fdbf01

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

This commit is  a good idea but one must be careful about one thing:

if the test does VERIFY_IS_NOT_APPROX, this is currently defined as

#define VERIFY_IS_NOT_APPROX(a, b) VERIFY(!test_ei_isApprox(a, b))

so it will output to cerr whenever it succeeds! The fix is probably to
introduce a separate test_isNotApprox or something like that.

Another thing is that for consistency, VERIFY_IS_EQUAL should do the samel.


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/