| [eigen] about eebce0fdbf01 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>, Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
- Subject: [eigen] about eebce0fdbf01
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Fri, 21 May 2010 07:18:57 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=/i5h3qcbihY6LORnBbMIMLe6fV8iTNT4PObSH6+Cm58=; b=Gpw63OwpSQMyX7nleANoqzhpnZuZijU2wmK6yJfPeftWbG01DdIMjloWckQ8ZqHQLB cDsZfgqqxigmE60Ri5Z+wAqTAwBZvF6GSilv+XimVEbeu5E1Ht7mYxHBrCMtKXWKcVD6 RE4v6ivWDD4PNxnKinkOemRMP2XDWIeBK9LOk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=uRNUHuXDpn1qJq25tbA+XT0Kac2N7CZmn5SThX2+P9e+783n3tSp9FXbpcN7cx68r9 HYmqWNUenRqRTMFcvFrQJTD+EGmqIuynm2fM6LdKxHc7gVzvE8zhqMP70WHNBYQk588/ Jch/R6JCER6jjtl2kbK+8YcgJf4UQQBIQbaz4=
This commit is a good idea but one must be careful about one thing:
if the test does VERIFY_IS_NOT_APPROX, this is currently defined as
#define VERIFY_IS_NOT_APPROX(a, b) VERIFY(!test_ei_isApprox(a, b))
so it will output to cerr whenever it succeeds! The fix is probably to
introduce a separate test_isNotApprox or something like that.
Another thing is that for consistency, VERIFY_IS_EQUAL should do the samel.
Benoit