[eigen] QR VS2008 compilation error

["SHIROKOBROD Oleg" <Oleg.Shirokobrod@xxxxxxxxxx>]

Hello,

 

MSVS 2008 issues an error message “Function should return a value” in functions

 

 

ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(const RealScalar& threshold)

    {

      m_usePrescribedThreshold = true;

      m_prescribedThreshold = threshold;

    }

ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(Default_t)

    {

      m_usePrescribedThreshold = false;

    }

 

In the file Eigen\src\QR\ ColPivHouseholderQR.h

 

I guess they should return selfreference:

 

ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(const RealScalar& threshold)

    {

      m_usePrescribedThreshold = true;

      m_prescribedThreshold = threshold;

      return *this;

    }

ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(Default_t)

    {

      m_usePrescribedThreshold = false;

      return *this;

    }

 

 

Thanks,

 

Oleg Shirokobrod

 

 

___________________________________________________________________________
This e-mail is confidential and is for the addressee only.   Please refer to
www.oxinst.com/email-statement for regulatory information.