| Re: [eigen] QR VS2008 compilation error |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] QR VS2008 compilation error
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Thu, 27 May 2010 13:16:11 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=rQ//h6KERa9Yhf7VBuU6+LJyyD592GnYMXuV+QB44hc=; b=EG7+ZTxkwXQyMTE/y5u/Ot64lCJIKvyc97gRdx80cJ2seqwfFZxHdCIebs6Okxaw9p ie/b9UvI5L6riUDh2T1rHQkxknmVwJDNMRBsNCDFURh+e+VKENQ8Gqp9EvnKAi8z74Fg tjC8914P8BiJNDQAqs+pFdC/CdV33RU5Xf68I=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=se1oZE6tfvABO8lfa+pl9zxD8d/D5X6FhrMn2+xzmhVHip4hwM+92IbTcclWhJE2cw oPvTIYP2JfSGySNC3T52pslWa9WKgRagPjWe//85CbBzrakUhiqBFvwbz+bk4okqJCmh MppDZJZMQN0ZVqlptfN46hQEHsvH75j/vWNic=
right, good catch. can somebody fix it? or can you make a patch? i'm
at work now.
http://eigen.tuxfamily.org/index.php?title=Developer's_Corner#Generating_a_patch
Benoit
2010/5/27 SHIROKOBROD Oleg <Oleg.Shirokobrod@xxxxxxxxxx>:
> Hello,
>
>
>
> MSVS 2008 issues an error message “Function should return a value” in
> functions
>
>
>
>
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(const RealScalar&
> threshold)
>
> {
>
> m_usePrescribedThreshold = true;
>
> m_prescribedThreshold = threshold;
>
> }
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(Default_t)
>
> {
>
> m_usePrescribedThreshold = false;
>
> }
>
>
>
> In the file Eigen\src\QR\ ColPivHouseholderQR.h
>
>
>
> I guess they should return selfreference:
>
>
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(const RealScalar&
> threshold)
>
> {
>
> m_usePrescribedThreshold = true;
>
> m_prescribedThreshold = threshold;
>
> return *this;
>
> }
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(Default_t)
>
> {
>
> m_usePrescribedThreshold = false;
>
> return *this;
>
> }
>
>
>
>
>
> Thanks,
>
>
>
> Oleg Shirokobrod
>
>
>
>
>
> ___________________________________________________________________________
> This e-mail is confidential and is for the addressee only. Please refer to
> www.oxinst.com/email-statement for regulatory information.