| Re: [eigen] Allocation policy of eigen decompositions |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Allocation policy of eigen decompositions
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Wed, 21 Apr 2010 12:58:31 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:content-type :content-transfer-encoding; bh=/Jjw3q2oNO3WyB2kIiK1lANiXNImiKSvFrojAiqm10M=; b=j3f245LIC2w8HWH7JNDXtEMrNbwWTLXKBwmpZZSG7Q+xwKbBiI5pIo1CFw9t2yZPaw sJ1mRhief3MbDl6/nHtFkZ6Y1I2RZlhi6LcvGEztM0g04o6/ANeU7YD1lV2Vm/2bFJqu 0ia8pbWDGlmy75WMePS4dxZQaMCA7NUMVkYE0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=qFWmXps9x3lrOL7dYqPJR7Arjx/UyjvSqWsjmUWqderhR75xl/DA+m3WizAgf2Jozm ES4XEJLU1r7b85tAXqPiKTkctEoCBvgIg1dR+6GSSOAtx7F1sd//OQO+yCVi2garbMQ2 26t5kgCwI4ZdvdqRfV2SkslRt0Dv89fmrzukg=
Thanks, this is pushed. Thanks also for updating the unit tests, and i
confirm they are successful. If you plan to continue with such great
contributions, why don't you create a bitbucket account so we can give
you write access?
Benoit
2010/4/21 Adolfo Rodríguez Tsouroukdissian <dofo79@xxxxxxxxx>:
> Please find attached a patch that:
>
> - Adds problem size constructor to decompositions that did not have one. It
> preallocates member data structures.
> - Updates unit tests to check above constructor.
> - In the compute() method of decompositions: Made temporary matrices/vectors
> class members to avoid heap allocations during compute() (when dynamic
> matrices are used, of course).
>
> These changes can speed up decomposition computation time when a single
> solver instance is used to solve multiple same-sized problems. An added
> benefit is that the compute() method can now be invoked in contexts were
> heap allocations are forbidden.
>
> CAVEAT: Not all of the decompositions in the Eigenvalues module have a
> heap-allocation-free compute() method. A future patch may address this
> issue, but some required API changes need to be incorporated first (see
> previous thread posts).
>
> Please let me know if something is not working as advertised ;)
>
> Regards,
>
> Adolfo
>
>
> --
> Adolfo Rodríguez Tsouroukdissian, Ph. D.
>
> Robotics engineer
> PAL ROBOTICS S.L
> http://www.pal-robotics.com
> Tel. +34.93.414.53.47
> Fax.+34.93.209.11.09
> AVISO DE CONFIDENCIALIDAD: Este mensaje y sus documentos adjuntos, pueden
> contener información privilegiada y/o confidencial que está dirigida
> exclusivamente a su destinatario. Si usted recibe este mensaje y no es el
> destinatario indicado, o el empleado encargado de su entrega a dicha
> persona, por favor, notifíquelo inmediatamente y remita el mensaje original
> a la dirección de correo electrónico indicada. Cualquier copia, uso o
> distribución no autorizados de esta comunicación queda estrictamente
> prohibida.
>
> CONFIDENTIALITY NOTICE: This e-mail and the accompanying document(s) may
> contain confidential information which is privileged and intended only for
> the individual or entity to whom they are addressed. If you are not the
> intended recipient, you are hereby notified that any disclosure, copying,
> distribution or use of this e-mail and/or accompanying document(s) is
> strictly prohibited. If you have received this e-mail in error, please
> immediately notify the sender at the above e-mail address.
>