On Tue, Mar 9, 2010 at 3:35 AM, Benoit Jacob
<jacob.benoit.1@xxxxxxxxx> wrote:
2010/3/8 Adolfo Rodríguez Tsouroukdissian <dofo79@xxxxxxxxx>:
> <snip>
>>>
>>> >>>>> >>> Supreme refinement is to add a unit test for that. We already
>>> >>>>> >>> have
>>> >>>>> >>> the
>>> >>>>> >>> skeleton in the nomalloc test (test/nomalloc.cpp). Indeed, when
>>> >>>>> >>> EIGEN_NO_MALLOC is defined, any heap allocation will cause an
>>> >>>>> >>> assert
>>> >>>>> >>> failure, which in the context of unit tests we convert into an
>>> >>>>> >>> exception.
>>> >>>>> >>>
>>> >>>>> >>> So don't hesitate to expand the nomalloc.cpp test, just with
>>> >>>>> >>> new
>>> >>>>> >>> executable targets (CALL_SUBTEST_x for a new value of x up to
>>> >>>>> >>> 16) so
>>> >>>>> >>> that no single executable gets too big. Testing only 'float' is
>>> >>>>> >>> good
>>> >>>>> >>> enough.
>
> </snip>
>
> I wouldn't call it supreme refinement ;) but here goes my patch. Feel free
> to voice out suggestions/improvements.
that helps a lot!
Nice to know we're giving back something useful, for Eigen is the kind of project that helps us a lot :D
Adolfo
Benoit
>
> Best,
>
> Adolfo
>