| Re: [eigen] [patch] LDLt decomposition with rank-deficient matrices |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] [patch] LDLt decomposition with rank-deficient matrices
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Tue, 23 Feb 2010 18:09:33 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=2uzwdkZiA6czjF/SF/K8/aDfjLBvnomgjpiHDxOHrDM=; b=f83W+6sGvD2ftRhEHRATmsl8o0iLl5EeA22oZs8YVd1KpoHny+63HJN/e2lgphILqp gc4sGcAHMK+FrMwrZ5cDSmkn5PoOl+xbD5K21F+crygxS8vNZO6g6Hith/HfnQlJ3qeR tFRnKknpQX12ivLVw5Uj+1o+bS7Pb+yjEvJDY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=EzkR+5fzN6yHWciOPBX7AkR1K5tGUsS3YzzITn43BQrRvlKrRA8YrGOc+iPOmrGZfr axfokr6piCR2VH3KcXa/gzbsCKIWLDxIZZ5NjUVaV40w77JNsQlufmFdIqDjNChXJZgh 7z8CsiVc/j7TYncfI4uBdCCSYIqHkfiVtF9KM=
2010/2/23 Ben Goodrich <bgokgm@xxxxxxxxxxxxxx>:
> Hi Benoit,
>
> On Tue, Feb 23, 2010 at 4:11 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
>
>> Both bugs fixed in the development branch.
>
> Thank you for fixing this. I agree that the previous test case is
> working now. You might have a look at the stable branch to see if it
> has the behavior you want, although it is assuming positive
> definiteness anyway. I would check myself except that this backported
> fix for the original problem of ldlt() not accepting Maps
>
> https://bitbucket.org/eigen/eigen/changeset/901a65334944/
>
> makes the stable branch not compile. I get these errors compiling that
> test case:
>
> In file included from /tmp/eigen/Eigen/Cholesky:36,
> from test.cc:1:
> /tmp/eigen/Eigen/src/Cholesky/LDLT.h: In member function ‘const
> Eigen::LDLT<typename Eigen::MatrixBase<Derived>::PlainMatrixType>
> Eigen::MatrixBase<Derived>::ldlt() const’:
> /tmp/eigen/Eigen/src/Cholesky/LDLT.h:195: error: ‘PlainObject’ was not
> declared in this scope
> /tmp/eigen/Eigen/src/Cholesky/LDLT.h:195: error: template argument 1 is invalid
>
> This just looks like an #include thing, but I will let someone more
> experienced with eigen patch it.
Fixed, thanks for the heads up.
Also, I committed a second precision fix to the 2.0 branch. It should
now be really precise. The trade-off is that isPositiveDefinite() now
always returns true (it never worked anyway, since this decomposition
is not rank-revealing, especially as in 2.0 it doesn't even use any
pivoting).
Benoit
>
> Thanks,
> Ben
>
>
>