| Re: [eigen] [patch] LDLt decomposition with rank-deficient matrices |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] [patch] LDLt decomposition with rank-deficient matrices
- From: Ben Goodrich <bgokgm@xxxxxxxxxxxxxx>
- Date: Tue, 23 Feb 2010 17:08:54 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=dOXDaf2B2v4C7nwKXcoJ2+YcrKXw6o2yczboikfMMyc=; b=GQ6mBX924ZpYxs9NMyupO3wb89GE6TVaiqIyv79fW0NpjKPRGhRrFhco9cNM7ex7ol FBlMgNOrBxQKLd+4GLCc58gHq7ptcFOoFxTt5QJd+kSUol74piGWZ541VUt7gXNquurW jUa5E6Oc6ZqkXp6NWpWOSPfb4vNlt9uHsIWHY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=oVK++TvfTvxwYYONO6C8OqBeuU9q8o+gqN/EKHEVt2atPkKvbiq8czJqMFEpCOuFtc JfPMZHESbmAEXAb+HE5OMgt+0ktjn+ehEPp+dk1isycfA/DuitcO2mLnEVHXYI4ZFzv2 ieVh30oJsUJpctZxiQh22r1Ks3twITodmYFmw=
Hi Benoit,
On Tue, Feb 23, 2010 at 4:11 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> Both bugs fixed in the development branch.
Thank you for fixing this. I agree that the previous test case is
working now. You might have a look at the stable branch to see if it
has the behavior you want, although it is assuming positive
definiteness anyway. I would check myself except that this backported
fix for the original problem of ldlt() not accepting Maps
https://bitbucket.org/eigen/eigen/changeset/901a65334944/
makes the stable branch not compile. I get these errors compiling that
test case:
In file included from /tmp/eigen/Eigen/Cholesky:36,
from test.cc:1:
/tmp/eigen/Eigen/src/Cholesky/LDLT.h: In member function ‘const
Eigen::LDLT<typename Eigen::MatrixBase<Derived>::PlainMatrixType>
Eigen::MatrixBase<Derived>::ldlt() const’:
/tmp/eigen/Eigen/src/Cholesky/LDLT.h:195: error: ‘PlainObject’ was not
declared in this scope
/tmp/eigen/Eigen/src/Cholesky/LDLT.h:195: error: template argument 1 is invalid
This just looks like an #include thing, but I will let someone more
experienced with eigen patch it.
Thanks,
Ben