[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] FFT update
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Fri, 22 Jan 2010 16:18:18 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=YVOK87fsHE083bXcKGm6f/vKj88DkbDd/JRgKt86jf8=; b=dZ1PfiRkkqZmX0tyoZd/9IjIB6FVJZtZvQ5AQeOY5SikqJ2kyfDZUjhQhZn1AtpXjD pIauHJPsOgLZr4XCuGRbYLjwXtGLXVZZRClABcfz6hP+xLNMCPjf/Ktj2sH5x4CwlHoR JegFlABSy6oL1XU0kLmN/QhzUwV5OOehEBlCc=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=EjGymp9ERce5fqYFu929phDPpJqmwtjePa+3Pf9LY2AfWB303SKGuw9J/HbCHHte3O zvvXpxFwL8r11/P5ezzelPsmksyXPCQEicPftfNq110xTTQD0ickfbwzMyj5WIHwz+g2 K7di9c7sxrCNcD1VwSNH1jCwD0cb/2eaenXR8=
On Fri, Jan 22, 2010 at 4:06 PM, Mark Borgerding <mark@xxxxxxxxxxxxxx> wrote:
> Glad to hear it. Thanks.
> One slight change that will be pushed soon is that the destination argument
> for fwd, inv functions is now a pointer. Benoit suggested this and I think
> it helps make it more obvious which is which.
Oh, and I thought we were done with this discussion. :)
>> First, you might want to consider taking DenseBase<Derived> as your
>> input parameter(s) as opposed to MatrixBase<Derived>. This allows us
>> to use the FFT module out of the box with the Array class.
>>
>
> I will look into this. I need to familiarize myself more with the Matrix
> inheritence tree anyway. I feel a bit "Dense" :)
This should be just a 'search and replace' operation but take your time.
>> Second, it would be a nice addition when we could adapt the
>> ReturnByValue class and thus making inv(...) and fwd(...) returning
>> their results.
>
> I think this would be a great addition. I don't think this would be
> confusing:
> stdVecDst = fft.fwd( stdVecSrc ); <=> fft.fwd( &stdVecDst,
> stdVecSrc );
> eigMatDst = fft.fwd( eigMatSrc); <=> fft.fwd(&eigMatSrc,
> eigMatDst );
This is what I meant when I said it won't be possible with the
overloads. For std::vector we cannot use the ReturnByValue. The class
is relying on internal Eigen assignment tricks...
Once again, thanks for all your effort!
- Hauke