| Re: [eigen] regression for operator != on matrix/array ? |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] regression for operator != on matrix/array ?
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Mon, 18 Jan 2010 08:21:12 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type; bh=Z71kb9wcfUF7Q7EpL+KLFI3p08j7XBTGxT/tH0GIPik=; b=uECAAtF9O91wiQda4RLgWOzb5SWh8PNIxyYqSNW8alHBQ4sQyk4hT+wu3JdMLbu0YR za9pHKZkF9TnQ4pR2pz6I82XzP6tFIECI1kDS1rFZ0ajs5HPmDaTzcsRqEDBSH3qh5Y+ mtf5kslA1R2AqYl446OSa3YrlCEKcExdDLmMk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=cemxZIdmf0Php3OKezqE5G8C9OtMoMI8Hh/h2tJA29XI+YS2LbwVOBlKTUu/Ku+p3N jHvp8CyMLxprnFyZk4QoemnB75wFr/Chw1aZ1Hz6Wuyzpul1wZOGSFT/jArMHOnaJTTE tpzU2uxDnhI/IhPkgMMBf+BG8fkZ0GW+zeVt8=
Hi, thanks for spotting that, and for the unit tests.
Actually, looking at MatrixBase::operator!= would have save you time
as the problem and respective fix was really obvious...
gael.
On Mon, Jan 18, 2010 at 12:02 AM, Thomas Capricelli
<orzel@xxxxxxxxxxxxxxx> wrote:
>
> Hi,
>
> Following the failure on some tests on my own projects, I've traced down the problem to operator!= for MatrixXd. My understanding is that operator== is ok, but operator!= gives 'true' even for different matrices.
>
> I added some unit tests (commit cc713769fdaa). Those tests currently fail, but I have tested them with revision 5875fb08124a and there they pass.
>
> Gael, 5875fb08124a is the last revision before your big 'array' merge. I guess something is your new implementation, but I can't find/fix it myself... maybe you have a clue ?
>
> regards,
> --
> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
> http://www.freehackers.org/thomas
>
>
>