Re: [eigen] vector-cwise operator +=/-= |

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

*To*: eigen@xxxxxxxxxxxxxxxxxxx*Subject*: Re: [eigen] vector-cwise operator +=/-=*From*: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>*Date*: Wed, 16 Dec 2009 10:05:30 +0100*Dkim-signature*: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=PfarY6POa8TJWhrCPB9xvUeLe8bAkXlF03TIlsGne5k=; b=xUv3hm2DiKSXfgXd3qwD50/jMeKFeYvWsBvVuK9B/S1tMpJtWAcBhzV2sGKj9YcKMC tiwniUQvaa54+PrdmBJgqcDPRE+Pg5aFU/1Zy8kbz4tD5qbuuJWUFmj/hLqqtgYdy+Lp DaYIBH2lUGMJmLlGV4UgAf8KB/uczxlGrfUYg=*Domainkey-signature*: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=Md4ZoZBjZ56MaiS7q6EBUtUa6HdYIgPaDf3+cZL2xmiXphhvK5FOTtq7Hsk5i3I4Mo 1LoOAcXuMYY+RQCbnRuaSCbTqtCoyVG853nUevuy+NAqJwBiyfovzRMT+QSwkxTrwIyh ZqfrEwzoCR+NNVq9dM0V5D78iz8lD/4Xx6Rv4=

indeed we already allow col_vector = row_vector, but I'm not sure we should allow coeff-wise binary operators to work between column and row vectors... is it always safe ? is it really more convenient ?

About the last question, e.g., your example is better written like this:

v3 += m.transpose() * v2;

gael

On Wed, Dec 16, 2009 at 9:39 AM, Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx> wrote:

Hi guys,

I think it would be cool, if the following code worked:

#include <Eigen/Core>

#include <Eigen/Array>

using namespace Eigen;

void main ()

{

Matrix<double,3,1> v3;

Matrix<double,2,1> v2;

Matrix<double,2,3> m;

m << 1,2,3,4,5,6;

v2 << 7,8;

v3 << 4,5,6;

v3 += v2.transpose() * m; // expected 43, 59, 57

std::cout << v3 << std::endl;

}

The simple assignment

v3 = v2.transpose() * m;

is already working and if I am not totally wrong, the only thing which keeps this current example from working is the ctor of CwiseBinaryOp. In particular the lines

EIGEN_STATIC_ASSERT_SAME_MATRIX_SIZE(Lhs, Rhs)

ei_assert(lhs.rows() == rhs.rows() && lhs.cols() == rhs.cols());

(these are redundant, right?). I think, if we simply make this check less restrictive in the sense that we allow the assignment of vectors and their transposed counterparts (having the same size...) we would be done. Any objections or comments against such a change?

- Hauke

**Follow-Ups**:**Re: [eigen] vector-cwise operator +=/-=***From:*Hauke Heibel

**References**:**[eigen] vector-cwise operator +=/-=***From:*Hauke Heibel

**Messages sorted by:**[ date | thread ]- Prev by Date:
**Re: [eigen] vector-cwise operator +=/-=** - Next by Date:
**Re: [eigen] vector-cwise operator +=/-=** - Previous by thread:
**Re: [eigen] vector-cwise operator +=/-=** - Next by thread:
**Re: [eigen] vector-cwise operator +=/-=**

Mail converted by MHonArc 2.6.19+ | http://listengine.tuxfamily.org/ |