Re: [eigen] vector-cwise operator +=/-=

[Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>]

Here is the patch I have in mind.

On Wed, Dec 16, 2009 at 9:39 AM, Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx> wrote:

Hi guys,

I think it would be cool, if the following code worked:

#include <Eigen/Core>
#include <Eigen/Array>

using namespace Eigen;

void main ()
{
  Matrix<double,3,1> v3;
  Matrix<double,2,1> v2;
  Matrix<double,2,3> m;

  m << 1,2,3,4,5,6;
  v2 << 7,8;
  v3 << 4,5,6;

  v3 += v2.transpose() * m; // expected 43, 59, 57
  std::cout << v3 << std::endl;
}

The simple assignment

v3 = v2.transpose() * m;

is already working and if I am not totally wrong, the only thing which keeps this current example from working is the ctor of CwiseBinaryOp. In particular the lines

EIGEN_STATIC_ASSERT_SAME_MATRIX_SIZE(Lhs, Rhs)
ei_assert(lhs.rows() == rhs.rows() && lhs.cols() == rhs.cols());

(these are redundant, right?). I think, if we simply make this check less restrictive in the sense that we allow the assignment of vectors and their transposed counterparts (having the same size...) we would be done. Any objections or comments against such a change?

- Hauke

Attachment: cwise_assign.patch
Description: Binary data