Re: [eigen] Quaternion and expression template

[Mathieu Gautier <mathieu.gautier@xxxxxx>]

Hauke Heibel a écrit :
> Mathieu, do you want to provide the patch - you already did all the 
> research? Otherwise, I will integrate it.

changelog :

* remove empty destructors in Matrix.h and MatrixStorage.h

--
Mathieu

# HG changeset patch
# User Mathieu Gautier <mathieu.gautier@xxxxxx>
# Date 1259748596 -3600
# Node ID 22db78091fadd7b8bd3bca8f93cd1f00f8927e18
# Parent  382c8411909e8be007ca303be9ea15ac52c102c7
* remove empty destructors in Matrix.h and MatrixStorage.h

diff -r 382c8411909e -r 22db78091fad Eigen/src/Core/Matrix.h
--- a/Eigen/src/Core/Matrix.h	Tue Dec 01 18:03:15 2009 -0500
+++ b/Eigen/src/Core/Matrix.h	Wed Dec 02 11:09:56 2009 +0100
@@ -536,9 +536,6 @@
       other.evalTo(*this);
     }
 
-    /** Destructor */
-    inline ~Matrix() {}
-
     /** \sa MatrixBase::operator=(const AnyMatrixBase<OtherDerived>&) */
     template<typename OtherDerived>
     EIGEN_STRONG_INLINE Matrix& operator=(const AnyMatrixBase<OtherDerived> &other)
diff -r 382c8411909e -r 22db78091fad Eigen/src/Core/MatrixStorage.h
--- a/Eigen/src/Core/MatrixStorage.h	Tue Dec 01 18:03:15 2009 -0500
+++ b/Eigen/src/Core/MatrixStorage.h	Wed Dec 02 11:09:56 2009 +0100
@@ -117,7 +117,6 @@
     inline ei_matrix_storage(ei_constructor_without_unaligned_array_assert)
       : m_data(ei_constructor_without_unaligned_array_assert()), m_rows(0), m_cols(0) {}
     inline ei_matrix_storage(int, int rows, int cols) : m_rows(rows), m_cols(cols) {}
-    inline ~ei_matrix_storage() {}
     inline void swap(ei_matrix_storage& other)
     { std::swap(m_data,other.m_data); std::swap(m_rows,other.m_rows); std::swap(m_cols,other.m_cols); }
     inline int rows(void) const {return m_rows;}
@@ -141,7 +140,6 @@
     inline ei_matrix_storage(ei_constructor_without_unaligned_array_assert)
       : m_data(ei_constructor_without_unaligned_array_assert()), m_rows(0) {}
     inline ei_matrix_storage(int, int rows, int) : m_rows(rows) {}
-    inline ~ei_matrix_storage() {}
     inline void swap(ei_matrix_storage& other) { std::swap(m_data,other.m_data); std::swap(m_rows,other.m_rows); }
     inline int rows(void) const {return m_rows;}
     inline int cols(void) const {return _Cols;}
@@ -163,7 +161,6 @@
     inline ei_matrix_storage(ei_constructor_without_unaligned_array_assert)
       : m_data(ei_constructor_without_unaligned_array_assert()), m_cols(0) {}
     inline ei_matrix_storage(int, int, int cols) : m_cols(cols) {}
-    inline ~ei_matrix_storage() {}
     inline void swap(ei_matrix_storage& other) { std::swap(m_data,other.m_data); std::swap(m_cols,other.m_cols); }
     inline int rows(void) const {return _Rows;}
     inline int cols(void) const {return m_cols;}