Re: [eigen] Re: Strong inlining is sometimes ignored...

[ Thread Index | Date Index | More Archives ]

2009/10/15 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> On Thu, Oct 15, 2009 at 7:20 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
> wrote:
>> > I just created a patch with all fixes...
>> So, I fully agree about the removal of the assert and the introduction
>> of the Length=0 specialization; I still need to be convinced about the
>> introduction of the template selector.
> That was an error from my side, again. Either we go for the Length=0
> specialization or for the template selector. At first I implemented the
> Length=0 specialization and at some point I thought the template selector
> might be the better solution. I am not sure - probably I was just afraid
> that the compiler does not automatically get rid of the dead if. I don't
> know, you decide.

OK. I have a slight preference for the Length=0 specialization,
because it doesn't add any nontrivial code, while the other solution
results in slight code duplication. But it's not a strong opinion.
Either way, feel free to push.


Mail converted by MHonArc 2.6.19+